[STALE] "Unfriendly" size offset flag #1258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdspring1
approved these changes
Nov 8, 2021
| @@ -148,12 +148,17 @@ static void Baseline_BatchNorm( | |||
| kMomentum, | |||
| kEps, | |||
| true); | |||
|
|
|||
| // aten::native_batch_norm_backward(Tensor grad_out, Tensor input, Tensor? | |||
csarofeen
force-pushed
the
bad_benchmark_sizes
branch
from
ff4cd75
to
32d56cf
Compare
csarofeen
changed the title
|
Should still do this, just this PR is very stale in the benchmarks and should simply redo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a compile time flag to offset sizes used in benchmarks to easily set benchmark sizes to be non-power-2