Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csandman/small improvements #42

Merged
merged 10 commits into from
Jan 27, 2022
Merged

Csandman/small improvements #42

merged 10 commits into from
Jan 27, 2022

Conversation

csandman
Copy link
Owner

  • Switch ban-ts-comment rule from off to warn
  • Add onFocus and onBlur handlers from a wrapping FormControl
  • Prevent selection of the text in the Placeholder component
  • Prevent a disabled option component from changing styles on click
  • Remove undefined option from TagVariant type and move that logic into the useChakraSelectProps hook
  • Be more explicit about exporting types from the package
  • Replace the MultiValue components with Box and chakra.span to fix TS errors
  • Replace the ClearIndicator component with Box to fix TS errors
  • Change indicators to be more like the original react-select and allow custom children

@csandman csandman merged commit 572919d into main Jan 27, 2022
@csandman csandman deleted the csandman/small-improvements branch January 27, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant