Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reduce selected menu option styles specificity #338

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

csandman
Copy link
Owner

@csandman csandman commented Oct 10, 2024

This PR fixes the issue described in #308. It removes the _selected check for the menu option style overrides because it was too specific. Sorry for the delay on this one, I completely forgot about this being an issue. The fix basically just reverts the change that was made in v4.7.6: v4.7.5...v4.7.6#diff-282462b390


One also small change, is that I generalized the dependency version of react-select to be 5.8.x.

@csandman csandman linked an issue Oct 10, 2024 that may be closed by this pull request
6 tasks
Copy link

github-actions bot commented Oct 10, 2024

📊 Package size report   0.01%↑

File Before After
dist/index.js 16.5 kB -0.04%↓16.5 kB
dist/index.js.map 74.0 kB 0.02%↑74.0 kB
dist/index.mjs 15.1 kB -0.05%↓15.1 kB
dist/index.mjs.map 73.9 kB 0.02%↑74.0 kB
Total (Includes all files) 272.2 kB 0.01%↑272.2 kB
Tarball size 60.9 kB -0.03%↓60.9 kB
Unchanged files
File Size
dist/index.d.mts 21.1 kB
dist/index.d.ts 21.1 kB
LICENSE.md 1.1 kB
package.json 3.0 kB
README.md 46.3 kB

🤖 This report was automatically generated by pkg-size-action

@csandman csandman merged commit 2269b85 into main Oct 10, 2024
4 checks passed
@csandman csandman deleted the fix/selected-menu-option-styles branch October 10, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Version 4.7.6 breaks colors for selected item
1 participant