fix: Change package type back to default of "commonjs"
#331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
📊 Package size report -1.73%↓
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
csandman
commented
Sep 5, 2024
| "files": [ | ||
| "dist" | ||
| ], | ||
| "scripts": { | ||
| "build": "tsup", | ||
| "check-exports": "attw --pack .", |
There was a problem hiding this comment.
I also added the package @arethetypeswrong/cli in order to more easily ensure that the exports are set up correctly after every change, as this is the real thing I've been trying to make sure of.
jonahallibone
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #329
This PR removes the
"type": "module"config from thepackage.json, in order to fix the path that Jest is pulling the package from. I'm not really an expert on Jest and where it pulls it's imports from, but the issue #329 appears to be caused by a mismatch of ESM and CJS imports. The goal ofv4.9was really to enable ESM imports in general, and this still works without using themoduletype, because the ESM version is pulled using theexportsfield (if the environment is setup correctly).So, after changing the
typeback tocommonjs(by just removing it,commonjsis the default), the fix with the consistent IDs (#298) still appears to work fine for me in my test environment, so I'm fine with this approach. Plus, this actually better matches the package exports for bothreact-selectand@chakra-ui/react, which I generally try and align with as much as possible, so that's a plus.I tested this against the test file provided by @hatajoe and have verified that the test runs fine after this change.