-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove useBasicStyles
and rename other custom props
#322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
📊 Package size report -2.11%↓
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes to the custom props this package offers which will be breaking changes.
useBasicStyles
prop, and defaults the styles to those that were previously provided by it. This is a change I've been meaning to make for a while, as I came to really dislike the default styles I gave the dropdown indicator. Originally, it was styled to match theInputRightAddon
component, in order to create a visual separation between the dropdown indicator and the clear indicator. However, I grew to strongly dislike the way it visually clashed with the built-in select menu. Also, the original CodeSandbox example I provided for showing how to style the select more closely to the original Chakra select had more views than any other example sandbox that was provided, showing that this is how many people would prefer it to look anyway.selectedOptionColor
prop. A new prop was added a while ago to replace that one,selectedOptionColorScheme
, as some people were getting confused by the meaning of the original. So I took this opportunity to finally remove the old prop it replaced.hasStickyGroupHeaders
prop. I removed this from the documentation a long time ago, as it was only ever really an experimental way to style the grouped option headers so they'd stay in view while you scroll the list of options. It also had some problems with using the keyboard to navigate between options. They would disappear behind the header when you used the up arrow. So this change is also a long time coming.colorScheme
prop totagColorScheme
. There has been some confusion around what this prop actually means, and I realized the original name the prop had wasn't specific enough to it's purpose. It didn't make sense to have a specific prop forselectedOptionColorScheme
, and not be specific with the naming for thetagColorScheme
.All of these changes can be made automatically using the Codemod provided here