Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicting star exports bug #230

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fix conflicting star exports bug #230

merged 1 commit into from
Dec 9, 2022

Conversation

csandman
Copy link
Owner

@csandman csandman commented Dec 9, 2022

This PR is to fix a part of what's going on in #229, at least the main issue described. However, I don't believe this is a solution to making chakra-react-select work with the Nextjs 13 app directory structure, but it should at least remove the warning.

The warning is fixed by being more explicit about what to export from react-select's sub-packages instead of exporting all children.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eb2ceca:

Sandbox Source
chakra-react-select demo Configuration
chakra-react-select TS demo Configuration
chakra-react-select + next.js Configuration
chakra-react-select + next.js + typescript Configuration

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

📊 Package size report   -0.04%↓

File Before After
dist/cjs/index.js 2.7 kB -27.9%↓1.9 kB
dist/cjs/index.js.map 1.5 kB 6%↑1.6 kB
dist/esm/index.js 679 B -2.95%↓659 B
dist/esm/index.js.map 1.7 kB 12%↑1.9 kB
dist/types/index.d.ts 1.0 kB 17%↑1.2 kB
dist/types/index.d.ts.map 833 B 18%↑981 B
Total (Includes all files) 388.7 kB -0.04%↓388.5 kB
Tarball size 63.6 kB 0.04%↑63.6 kB
Unchanged files
File Size
dist/cjs/async-creatable-select.js 2.3 kB
dist/cjs/async-creatable-select.js.map 1.8 kB
dist/cjs/async-select.js 2.2 kB
dist/cjs/async-select.js.map 1.7 kB
dist/cjs/chakra-components/containers.js 3.7 kB
dist/cjs/chakra-components/containers.js.map 6.4 kB
dist/cjs/chakra-components/control.js 9.2 kB
dist/cjs/chakra-components/control.js.map 15.5 kB
dist/cjs/chakra-components/index.js 2.8 kB
dist/cjs/chakra-components/index.js.map 2.2 kB
dist/cjs/chakra-components/input.js 3.3 kB
dist/cjs/chakra-components/input.js.map 4.7 kB
dist/cjs/chakra-components/menu.js 11.2 kB
dist/cjs/chakra-components/menu.js.map 19.7 kB
dist/cjs/chakra-components/multi-value.js 6.0 kB
dist/cjs/chakra-components/multi-value.js.map 11.0 kB
dist/cjs/chakra-components/placeholder.js 1.7 kB
dist/cjs/chakra-components/placeholder.js.map 2.6 kB
dist/cjs/chakra-components/single-value.js 1.6 kB
dist/cjs/chakra-components/single-value.js.map 2.4 kB
dist/cjs/creatable-select.js 2.3 kB
dist/cjs/creatable-select.js.map 1.7 kB
dist/cjs/module-augmentation.js 61 B
dist/cjs/module-augmentation.js.map 9.3 kB
dist/cjs/select.js 2.2 kB
dist/cjs/select.js.map 1.5 kB
dist/cjs/types.js 47 B
dist/cjs/types.js.map 3.5 kB
dist/cjs/use-chakra-select-props.js 6.1 kB
dist/cjs/use-chakra-select-props.js.map 7.9 kB
dist/cjs/utils.js 1.8 kB
dist/cjs/utils.js.map 2.1 kB
dist/esm/async-creatable-select.js 855 B
dist/esm/async-creatable-select.js.map 1.9 kB
dist/esm/async-select.js 799 B
dist/esm/async-select.js.map 1.7 kB
dist/esm/chakra-components/containers.js 3.2 kB
dist/esm/chakra-components/containers.js.map 6.5 kB
dist/esm/chakra-components/control.js 8.4 kB
dist/esm/chakra-components/control.js.map 15.7 kB
dist/esm/chakra-components/index.js 1.3 kB
dist/esm/chakra-components/index.js.map 2.5 kB
dist/esm/chakra-components/input.js 3.0 kB
dist/esm/chakra-components/input.js.map 4.8 kB
dist/esm/chakra-components/menu.js 10.4 kB
dist/esm/chakra-components/menu.js.map 19.8 kB
dist/esm/chakra-components/multi-value.js 5.5 kB
dist/esm/chakra-components/multi-value.js.map 11.2 kB
dist/esm/chakra-components/placeholder.js 1.5 kB
dist/esm/chakra-components/placeholder.js.map 2.6 kB
dist/esm/chakra-components/single-value.js 1.3 kB
dist/esm/chakra-components/single-value.js.map 2.5 kB
dist/esm/creatable-select.js 823 B
dist/esm/creatable-select.js.map 1.8 kB
dist/esm/module-augmentation.js 58 B
dist/esm/module-augmentation.js.map 9.3 kB
dist/esm/select.js 767 B
dist/esm/select.js.map 1.6 kB
dist/esm/types.js 44 B
dist/esm/types.js.map 3.5 kB
dist/esm/use-chakra-select-props.js 5.8 kB
dist/esm/use-chakra-select-props.js.map 7.9 kB
dist/esm/utils.js 1.7 kB
dist/esm/utils.js.map 2.1 kB
dist/types/async-creatable-select.d.ts 624 B
dist/types/async-creatable-select.d.ts.map 636 B
dist/types/async-select.d.ts 550 B
dist/types/async-select.d.ts.map 608 B
dist/types/chakra-components/containers.d.ts 704 B
dist/types/chakra-components/containers.d.ts.map 322 B
dist/types/chakra-components/control.d.ts 1.7 kB
dist/types/chakra-components/control.d.ts.map 589 B
dist/types/chakra-components/index.d.ts 5.1 kB
dist/types/chakra-components/index.d.ts.map 208 B
dist/types/chakra-components/input.d.ts 295 B
dist/types/chakra-components/input.d.ts.map 237 B
dist/types/chakra-components/menu.d.ts 1.3 kB
dist/types/chakra-components/menu.d.ts.map 490 B
dist/types/chakra-components/multi-value.d.ts 1.1 kB
dist/types/chakra-components/multi-value.d.ts.map 432 B
dist/types/chakra-components/placeholder.d.ts 325 B
dist/types/chakra-components/placeholder.d.ts.map 252 B
dist/types/chakra-components/single-value.d.ts 326 B
dist/types/chakra-components/single-value.d.ts.map 254 B
dist/types/creatable-select.d.ts 582 B
dist/types/creatable-select.d.ts.map 616 B
dist/types/module-augmentation.d.ts 9.5 kB
dist/types/module-augmentation.d.ts.map 2.0 kB
dist/types/select.d.ts 472 B
dist/types/select.d.ts.map 556 B
dist/types/types.d.ts 3.2 kB
dist/types/types.d.ts.map 3.3 kB
dist/types/use-chakra-select-props.d.ts 613 B
dist/types/use-chakra-select-props.d.ts.map 255 B
dist/types/utils.d.ts 631 B
dist/types/utils.d.ts.map 214 B
LICENSE.md 1.1 kB
package.json 4.0 kB
README.md 45.6 kB

🤖 This report was automatically generated by pkg-size-action

@csandman csandman merged commit 4752de8 into main Dec 9, 2022
@csandman csandman deleted the star-exports-fix branch December 9, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant