Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds Variant prop that reflects chackra-ui variants #167

Merged
merged 4 commits into from
Sep 1, 2022

Conversation

picninim
Copy link

fix: Extra padding when flushed styled was applied

This feature allow users to use different appearances in the same project

…rom inputs and selects

fix: Extra padding when flushed styled was applied

This feature allow users to use different apperances in the same project
@csandman
Copy link
Owner

This looks good! However, I think using variant instead of appearanceVariant would be better, just for simplicity's sake. If you make that change I'll merge. I'll probably tweak the documentation a bit before I publish it but you don't need to worry about that, I can handle it.

@picninim picninim changed the title feat: Adds appearanceVariant prop that reflects chackra-ui variants feat: Adds Variant prop that reflects chackra-ui variants Aug 29, 2022
@picninim
Copy link
Author

picninim commented Aug 29, 2022

This looks good! However, I think using variant instead of appearanceVariant would be better, just for simplicity's sake. If you make that change I'll merge. I'll probably tweak the documentation a bit before I publish it but you don't need to worry about that, I can handle it.

Done! :D I am happy to help !

@csandman csandman self-requested a review August 30, 2022 03:50
@csandman csandman merged commit 9f90db5 into csandman:main Sep 1, 2022
@csandman
Copy link
Owner

csandman commented Sep 1, 2022

Ok I made the changes I needed in order to approve (mostly documentation and organization changes) and published them in v4.2.0! You can see the docs for you new feature here:

@csandman
Copy link
Owner

csandman commented Sep 1, 2022

You can see a demo for the prop here: https://codesandbox.io/s/chakra-react-select-variant-5cf755?file=/example.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants