Not compatible with flake8 5.0

[NeilGirdhar]

  File "/Users/neil/Library/Caches/pypoetry/virtualenvs/generators-0uytuYoH-py3.10/lib/python3.10/site-packages/pflake8/__init__.py", line 54, in <module>
    class ModifiedConfigFileFinder(flake8.options.config.ConfigFileFinder):
AttributeError: module 'flake8.options.config' has no attribute 'ConfigFileFinder'

[schinckel]

Looks like this class went away: instead the files that are checked are hard-coded inside a function:

https://github.com/PyCQA/flake8/blame/91a7fa9ac360be7f43b1325875cf5bf4fe89e380/src/flake8/options/config.py#L31

One alternative could be to use something like patchy to change this.

[NeilGirdhar]

@schinckel That's a good idea!

[wieczorek1990]

Please see here:
PyCQA/flake8#1634

[wieczorek1990]

And here:
#14

[NeilGirdhar]

Please see here:
PyCQA/flake8#1634

The MyPy team accepted a similar pull request from me ages ago python/mypy#11584. Even from a code quality standpoint, having constants at the top level rather than embedded within code is good style. It seems like Anthony is going out of his way to interfere with this project.

And here: #14

Thanks, this helps.

[wieczorek1990]

For me this is unnamed constant. But sure it’s not monkey patchable this way. W dniu pon., 1.08.2022 o 15:56 Neil Girdhar ***@***.***> napisał(a):

…

Please see here: PyCQA/flake8#1634 <PyCQA/flake8#1634> The MyPy team accepted a similar pull request from me ages ago python/mypy#11584 <python/mypy#11584>. Even from a code quality standpoint, having constants at the top level rather than embedded within code is good style. I think that is a bad decision from Anthony. And here: #14 <#14> Thanks, this helps. — Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMRLK4SQQSVLFRGXPDSWE3VW7JRBANCNFSM55FQJQIA> . You are receiving this because you commented.Message ID: ***@***.***>

[wieczorek1990]

Updated the pull request #14, so that it's compatible with flake8 version 5.

[jaklan]

@NeilGirdhar

It seems like Anthony is going out of his way to interfere with this project.

The Anthony's fight against toml is one of the must frustrating things I have ever seen in the Python community. One guy doesn't like the agreed standard, so he does everything to sabotage its adoption... Anyway, I really cross my fingers for resolving the issue, so we could stay with pyproject.toml-only configs again!