Feature/evse

[mmb-davidsmith]

EVSE work

[mmb-davidsmith]

I would highly suggest taking a look at how this is handled in the Image Block Response in OTA. The XML schema allows us to specify a presentIf value for fields which would allow us to make certain fields only present based on EvseState.

[iwinterburn]

Question/proposal made separately

[jmeg-sfy]

is it solved ?

[iwinterburn]

Question/proposal made separately

[iwinterburn]

Client command IDs updated as requested

[jmeg-sfy]

So it need to be added here ? on this line ?
What is missing to get this PR merged @iwinterburn ?

[iwinterburn]

Some attribute default values agreed on Sept 27 BG call.
Clinet Command IDs renumbered to ovoid overlap with Server command (0x01)

[jmeg-sfy]

Hello i did an update to rebase + fixe Ian comments

[jmeg-sfy]

@mmb-davidsmith I took the liberty to rebase force push into your branch

[michaelleecowan]

Hello, A good XML editor is Sublime Thanks, Michael Michael Cowan Principal System Engineer Xylem 639 Davis Drive Morrisville NC 27560 HomeO: +1.919.469.2453 | M: +1.919.602.6629 | Lab: +1.919.317.6320 [signature_1839051095]<https://xylem.com/?utm_source=signature&utm_medium=email&utm_campaign=corporate> Xylem.com<https://xylem.com/?utm_source=signature&utm_medium=email&utm_campaign=corporate> | Sensus.com<https://sensus.com/?utm_source=signature&utm_medium=email&utm_campaign=corporate> LinkedIn<https://www.linkedin.com/company/sensus> | Twitter<https://twitter.com/SensusGlobal> | YouTube<https://www.youtube.com/c/SensusGlobal> | Facebook<https://www.facebook.com/SensusGlobal/> | Instagram<https://www.instagram.com/sensusglobal/> | 3D Tour<https://apps.kaonadn.net/5277329597136896/index.html> From: iwinterburn ***@***.***> Sent: Thursday, December 22, 2022 4:19 AM To: csa-iot/data-model ***@***.***> Cc: Cowan, Michael - Xylem ***@***.***>; Comment ***@***.***> Subject: Re: [csa-iot/data-model] Feature/evse (PR #6) @iwinterburn commented on this pull request.

________________________________ In EVSEManagement.xml<https://urldefense.com/v3/__https:/github.com/csa-iot/data-model/pull/6*discussion_r1055249803__;Iw!!OKzgfr8!deWPpuXMxMcJ2FWLxmjy_3HnbmXC4FqEdcFPzicpMwXpDkSiMnJF5GNyNrOtwqoI2P8d02DmKPtzg1T9SFXhwtHBIKpiNg$>:

+ <attribute id="0001" name="SupplyState" type="EvseSupplyState" required="true" default="0" />

+ <attribute id="0002" name="EvseType" type="EvseType" required="true" default="0" /> + <attribute id="0003" name="EvseFault" type="EvseFault" required="true" default="0" /> + <attribute id="0004" name="EvseEnableChargeTime" type="uint16" max="65535" required="true" default="65535" /> + <attribute id="0005" name="EvseEnableDischargeTime" type="uint16" max="65535" default="0" /> + <attribute id="0006" name="MinimumChargeCurrent" type="uint16" required="true" default="6" /> + <attribute id="0007" name="MaximumChargeCurrent" type="uint16" required="true" default="15" /> + <attribute id="0008" name="MaximumDischargeCurrent" type="uint16" default="15" /> + <attribute id="0009" name="EvseInternalTemperature" type="int16" /> + <attribute id="000A" name="BatteryLevel" type="uint8" required="true" reportRequired="true" max="100" default="255" /> + <attribute id="000B" name="BatteryCapacity" type="uint16" required="true" default="65535" /> + <attribute id="000C" name="CircuitId" type="uint16" /> + <attribute id="000D" name="CircuitCapacity" type="uint16" /> + + <!-- Attribute Set 0x01: Reading Information --> + <attribute id="0100" name="ChargingVoltage" type="uint16" required="true" max="65535" /> ChargingValue default clarified to 0xFFFF by BG on 2022/09/27 — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/csa-iot/data-model/pull/6*pullrequestreview-1227350078__;Iw!!OKzgfr8!deWPpuXMxMcJ2FWLxmjy_3HnbmXC4FqEdcFPzicpMwXpDkSiMnJF5GNyNrOtwqoI2P8d02DmKPtzg1T9SFXhwtGvaX-Pjg$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ALTQZPGYUDGZTIRVTCOQUADWOQMIPANCNFSM55TC74ZQ__;!!OKzgfr8!deWPpuXMxMcJ2FWLxmjy_3HnbmXC4FqEdcFPzicpMwXpDkSiMnJF5GNyNrOtwqoI2P8d02DmKPtzg1T9SFXhwtGpEWXdcw$>. You are receiving this because you commented.Message ID: ***@***.******@***.***>> CONFIDENTIALITY NOTICE: This e-mail, including any attachments and/or linked documents, is intended for the sole use of the intended addressee and may contain information that is privileged, confidential, proprietary, or otherwise protected by law. Any unauthorized review, dissemination, distribution, or copying is prohibited. If you have received this communication in error, please contact the original sender immediately by reply email and destroy all copies of the original message and any attachments. Please note that any views or opinions presented in this e-mail are solely those of the author and do not necessarily represent those of Xylem Inc..