Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass proper logger down to datatx handler and tus #4935

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Nov 13, 2024

pass a properly initialized logger to tus.

it will log sth like:

2024-11-14T11:55:27+01:00 WRN NetworkControlError datatx=tus line=/home/jfd/Repositories/reva/pkg/rhttp/datatx/manager/tus/tus.go:251 method={} path={} pkg=rhttp requestId={} service=storage-users
2024-11-14T11:55:27+01:00 INF RequestIncoming datatx=tus line=/home/jfd/Repositories/reva/pkg/rhttp/datatx/manager/tus/tus.go:249 method={} path={} pkg=rhttp requestId={} service=storage-users
2024-11-14T11:55:27+01:00 INF ChunkWriteStart datatx=tus id={} line=/home/jfd/Repositories/reva/pkg/rhttp/datatx/manager/tus/tus.go:249 method={} path={} pkg=rhttp requestId={} service=storage-users
2024-11-14T11:55:27+01:00 WRN NetworkTimeoutError datatx=tus id={} line=/home/jfd/Repositories/reva/pkg/rhttp/datatx/manager/tus/tus.go:251 method={} path={} pkg=rhttp requestId={} service=storage-users
2024-11-14T11:55:27+01:00 INF ChunkWriteComplete datatx=tus id={} line=/home/jfd/Repositories/reva/pkg/rhttp/datatx/manager/tus/tus.go:249 method={} path={} pkg=rhttp requestId={} service=storage-users
2024-11-14T11:55:27+01:00 INF UploadFinished datatx=tus id={} line=/home/jfd/Repositories/reva/pkg/rhttp/datatx/manager/tus/tus.go:249 method={} path={} pkg=rhttp requestId={} service=storage-users
2024-11-14T11:55:27+01:00 INF ResponseOutgoing datatx=tus id={} line=/home/jfd/Repositories/reva/pkg/rhttp/datatx/manager/tus/tus.go:249 method={} path={} pkg=rhttp requestId={} service=storage-users
2024-11-14T11:55:27+01:00 DBG http end="14/Nov/2024:11:55:27 +0100" host=127.0.0.1 line=/home/jfd/Repositories/reva/internal/http/interceptors/log/log.go:112 method=PATCH pkg=rhttp proto=HTTP/1.1 service=storage-users size=0 start="14/Nov/2024:11:55:27 +0100" status=204 time_ns=25707586 traceid=07b8bc72a6bb2f9df54baf8a494c32e6 uri=/data/tus/d4817c6b-dd30-4f02-b4fb-183f703384d4 url=/d4817c6b-dd30-4f02-b4fb-183f703384d4

not perfect, but we should at least see errors in the logs now.

@butonic butonic self-assigned this Nov 13, 2024
Copy link

update-docs bot commented Nov 13, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@aduffeck aduffeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@micbar
Copy link
Member

micbar commented Nov 14, 2024

@butonic please rebase to get the PosixFS test pipeline fixes.

@butonic
Copy link
Contributor Author

butonic commented Nov 14, 2024

➜  reva git:(edge) ✗ git pull
Bereits aktuell.
➜  reva git:(edge) ✗ git rebase edge                            
Aktueller Branch edge ist auf dem neuesten Stand.
➜  reva git:(edge) ✗ git checkout log-uploads                   
Zu Branch 'log-uploads' gewechselt
Ihr Branch ist auf demselben Stand wie 'origin/log-uploads'.
➜  reva git:(log-uploads) ✗ git rebase edge
Aktueller Branch log-uploads ist auf dem neuesten Stand.
➜  reva git:(log-uploads) ✗

@micbar micbar marked this pull request as ready for review November 19, 2024 07:43
@micbar micbar requested review from labkode, glpatcern and a team as code owners November 19, 2024 07:43
@micbar micbar merged commit 6f05da6 into cs3org:edge Nov 19, 2024
10 checks passed
@micbar micbar mentioned this pull request Nov 21, 2024
87 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants