Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error type #4926

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix error type #4926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion changelog/unreleased/fix-download-consistency.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
Bugfix: make etag always matche content on downloads
Bugfix: make etag always match content on downloads

We added an openReaderfunc to the Download interface to give drivers a way to guarantee that the reader matches the etag returned in a previous GetMD call.

https://github.com/cs3org/reva/pull/4926
https://github.com/cs3org/reva/pull/4923

2 changes: 1 addition & 1 deletion pkg/storage/utils/decomposedfs/decomposedfs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,7 @@ func (fs *Decomposedfs) Download(ctx context.Context, ref *provider.Reference, o

n, err := fs.lu.NodeFromResource(ctx, ref)
if err != nil {
return nil, nil, errors.Wrap(err, "Decomposedfs: error resolving ref")
return nil, nil, err
}

if !n.Exists {
Expand Down
Loading