-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sharejail stat #4835
Fix sharejail stat #4835
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
9e04421
to
2964a28
Compare
@micbar since you are knee deep in wopi work can you try this out with a working wopi setup? |
@butonic Is there any way (test instance or similar) that we could use to verify if it fixes the issue for the iOS app and/or if there are any other side effects? |
You could use the ocis_full docker compose locally on this branch. Checkout this branch, then
|
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
2964a28
to
02af5a2
Compare
while the implementation is correct, the ocis testsuite needs a fix: owncloud/ocis#10172 (comment) |
test got added to expected failures, merging |
Stating a share jail mountpoint now returns the same resourceid as in the directory listing of the share jail root.
This needs to be tested with WOPI, as I fear the web client might now try to use the sharejail id to access a resource ...
see owncloud/ocis#9933