Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit max number of entries when listing recycle bin #4455

Merged
merged 16 commits into from
Feb 14, 2024

Conversation

glpatcern
Copy link
Member

@glpatcern glpatcern commented Jan 10, 2024

This PR introduces support for from and to dates when listing the recycle bin (by default no more than 14 days, configurable), as well as a (configurable) cap on the number of entries returned to the web UI.

The cap is obtained by eos recycle ls max-entries as well as via GRPC. This feature was released in eos 5.2.7.

We also update the clients in the test CI to eos 5.2.14, as new clients are not compatible with old ones, and the listing is to be performed with eos oldfind as opposed to eos find.

Copy link

update-docs bot commented Jan 10, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@labkode
Copy link
Member

labkode commented Jan 10, 2024

Goes into the right direction, we can add the date parameter to it as it was in the past:
cernbox/revaold@607bfc1

@glpatcern glpatcern force-pushed the eos-recycle branch 8 times, most recently from c424d1f to 2a362f5 Compare January 12, 2024 21:19
@glpatcern glpatcern marked this pull request as ready for review January 15, 2024 12:56
@glpatcern glpatcern requested a review from a team as a code owner January 15, 2024 12:56
@glpatcern glpatcern force-pushed the eos-recycle branch 2 times, most recently from 9bcdd02 to b0dc88a Compare January 19, 2024 10:30
@labkode
Copy link
Member

labkode commented Jan 30, 2024

For record, while debugging the recycle issue on CERNBox, we saw that the limit of 14 days was not enforced, needs to be checked. We saw hundreds of recycle ls calls being sent to EOS instead of only 14.

@diocas

@diocas
Copy link
Contributor

diocas commented Jan 30, 2024

This happened in the test instance, where the UI was not sending any to from.

@glpatcern
Copy link
Member Author

Yep, I saw that yesterday, but the backend must be resilient to that (default to last 14 days). Debugging it

@glpatcern glpatcern marked this pull request as draft January 30, 2024 11:52
@glpatcern glpatcern force-pushed the eos-recycle branch 2 times, most recently from 3a8556a to 7016394 Compare February 1, 2024 17:37
@glpatcern glpatcern marked this pull request as ready for review February 2, 2024 08:48
@glpatcern
Copy link
Member Author

glpatcern commented Feb 2, 2024

This now works (modulo the GRPC part, still to be completed), but requires eos 5.2.6+, therefore to be merged only after we have completed the current eos deployment campaign.

@glpatcern glpatcern force-pushed the eos-recycle branch 3 times, most recently from 3f69fe0 to 79a90a6 Compare February 6, 2024 12:21
@glpatcern glpatcern force-pushed the eos-recycle branch 2 times, most recently from 297909b to 99613ff Compare February 12, 2024 10:59
@glpatcern
Copy link
Member Author

Fully tested. The eosbinary works with eos 5.2.6+ on the server, the eosgrpc requires eos 5.2.13+ on the server. In all cases, eos 5.2.13+ is required as client where reva runs.

@glpatcern glpatcern merged commit 34a5ffb into cs3org:master Feb 14, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants