-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit max number of entries when listing recycle bin #4455
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
4581b58
to
8efa047
Compare
af01062
to
6c2a033
Compare
Goes into the right direction, we can add the date parameter to it as it was in the past: |
c424d1f
to
2a362f5
Compare
9bcdd02
to
b0dc88a
Compare
For record, while debugging the recycle issue on CERNBox, we saw that the limit of 14 days was not enforced, needs to be checked. We saw hundreds of recycle ls calls being sent to EOS instead of only 14. |
This happened in the test instance, where the UI was not sending any |
Yep, I saw that yesterday, but the backend must be resilient to that (default to last 14 days). Debugging it |
3a8556a
to
7016394
Compare
This now works (modulo the GRPC part, still to be completed), but requires eos 5.2.6+, therefore to be merged only after we have completed the current eos deployment campaign. |
7016394
to
a5fce00
Compare
3f69fe0
to
79a90a6
Compare
…ted for eos drivers
…ror is sent if exceeded
…too long" error handling
297909b
to
99613ff
Compare
99613ff
to
4b9d815
Compare
Fully tested. The eosbinary works with eos 5.2.6+ on the server, the eosgrpc requires eos 5.2.13+ on the server. In all cases, eos 5.2.13+ is required as client where reva runs. |
f0574a0
to
b5fcbfc
Compare
b5fcbfc
to
d534163
Compare
This PR introduces support for
from
andto
dates when listing the recycle bin (by default no more than 14 days, configurable), as well as a (configurable) cap on the number of entries returned to the web UI.The cap is obtained by
eos recycle ls max-entries
as well as via GRPC. This feature was released in eos 5.2.7.We also update the clients in the test CI to eos
5.2.14
, as new clients are not compatible with old ones, and the listing is to be performed witheos oldfind
as opposed toeos find
.