Support multiple token strategies in auth middleware #4030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmgigi96
force-pushed
the
multiple-token-strategies
branch
from
d47ebbb
to
a314111
Compare
labkode
approved these changes
Jul 3, 2023
glpatcern
approved these changes
Jul 3, 2023
abaldacchino
pushed a commit
to abaldacchino/reva
that referenced
this pull request
Aug 25, 2023
* support multiple token strategies in auth middleware * add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different HTTP services can in general support different token strategies for validating the reva token, for example all the clients of a the data provider are including the token in the
x-access-tokenheader, while the CERNBox web interface is using the bearer authentication.In this context, without updating every single client a mono process deployment will never work.
Now the HTTP auth middleware accepts in its configuration a token strategy chain, allowing to provide the reva token in multiple places (bearer auth, header).