Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide total transfer size with the datatx protocol #3891

Merged
merged 2 commits into from
May 17, 2023

Conversation

redblom
Copy link
Contributor

@redblom redblom commented May 16, 2023

Sets the size property of the OCM share's datatx protocol (#2104).

@redblom redblom requested review from labkode, gmgigi96, glpatcern and a team as code owners May 16, 2023 08:43
@redblom redblom force-pushed the datatx-transfer-size branch 2 times, most recently from 0d34d34 to 6e0bd0c Compare May 16, 2023 08:53
@redblom redblom changed the title Provide total file size with the datatx protocol Provide total transfer size with the datatx protocol May 16, 2023
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only one comment

@gmgigi96 gmgigi96 requested a review from glpatcern May 16, 2023 15:34
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it appears that this use of panic to just assert something that was already validated is relatively common in Go-lang (though not so widespread in the Reva code base).

@glpatcern glpatcern merged commit c6072ab into cs3org:master May 17, 2023
gmgigi96 pushed a commit to gmgigi96/reva that referenced this pull request Jun 5, 2023
* Provide total file size with the datatx protocol

* Lint fix

---------

Co-authored-by: Antoon P <[email protected]>
gmgigi96 pushed a commit to gmgigi96/reva that referenced this pull request Jun 28, 2023
* Provide total file size with the datatx protocol

* Lint fix

---------

Co-authored-by: Antoon P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants