-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide total transfer size with the datatx protocol #3891
Conversation
0d34d34
to
6e0bd0c
Compare
6e0bd0c
to
8b4e4c4
Compare
8b4e4c4
to
552898b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, it appears that this use of panic
to just assert something that was already validated is relatively common in Go-lang (though not so widespread in the Reva code base).
* Provide total file size with the datatx protocol * Lint fix --------- Co-authored-by: Antoon P <[email protected]>
* Provide total file size with the datatx protocol * Lint fix --------- Co-authored-by: Antoon P <[email protected]>
Sets the
size
property of the OCM share's datatx protocol (#2104).