Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest user/group drivers: refactor and fix user type for lw accounts #3821

Merged
merged 6 commits into from
May 3, 2023

Conversation

gmgigi96
Copy link
Member

@gmgigi96 gmgigi96 commented Apr 26, 2023

This PR add the following fix/enhancement to the rest user and group drivers:

  • Fix the user type for lightweight accounts, using the source field to differentiate between a primary and lw account
  • Remove all the code with manual parsing of the json returned by the CERN provider
  • Introduce pagination for GetMembers method in the group driver
    • the result without pagination was truncated to the first 1000 items
  • Reduced network transfer size by requesting only needed fields for GetMembers method

@gmgigi96 gmgigi96 changed the title rest user driver: refactor and fix user type for lw accounts rest user/group drivers: refactor and fix user type for lw accounts Apr 26, 2023
@gmgigi96 gmgigi96 marked this pull request as ready for review May 2, 2023 13:02
@gmgigi96 gmgigi96 requested review from labkode, glpatcern and a team as code owners May 2, 2023 13:02
@cs3org cs3org deleted a comment from hound bot May 2, 2023
@glpatcern glpatcern merged commit 57cec27 into cs3org:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants