Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial favorites support #372

Merged
merged 1 commit into from
Nov 18, 2019
Merged

initial favorites support #372

merged 1 commit into from
Nov 18, 2019

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Nov 13, 2019

good enough for testing

  • only works for the owncloud storage driver
    • eos and actually any storage drive would have to take into account if a property is user specific or not...
      • user individual metadata sucks
    • storing them in extended file attributes would leak favorites (and tags) but more flawed: users can make any of their owned files a favorite for another user by writing the corresponding xattr ... we need to check if we can use a xattr namespace (TRUSTED?) that requires a different privilege... see CAP_SYS_ADMIN and how to set it
      • CAP_SYS_ADMIN way to powerful a capability. friends don't let friends run reva as root ...
  • we can learn from this and reimplement favorites on top of a proper tagging service

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic marked this pull request as ready for review November 14, 2019 15:04
@labkode
Copy link
Member

labkode commented Nov 18, 2019

@butonic I merge now but let's follow up on the discussion on CS3, I'll involve Andreas from EOS as he is dealing with the same challenge :)

@labkode labkode merged commit e75eed9 into cs3org:master Nov 18, 2019
@butonic butonic deleted the favorites branch November 22, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants