Enhancement: improve the wopi app driver #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbar
requested review from
labkode,
ishank011,
wkloucek and
glpatcern
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
micbar
force-pushed
the
wopi-driver-improvements
branch
from
e17c730
to
fb28bb6
Compare
micbar
force-pushed
the
wopi-driver-improvements
branch
2 times, most recently
from
0c0441f
to
8424a05
Compare
|
This is also a welcome improvement in |
butonic
approved these changes
Sep 30, 2022
micbar
force-pushed
the
wopi-driver-improvements
branch
2 times, most recently
from
be4cc9e
to
ad80d34
Compare
micbar
commented
Sep 30, 2022
micbar
force-pushed
the
wopi-driver-improvements
branch
from
ad80d34
to
d1ec2bf
Compare
I plan to use the private link which not be user facing in the future in ocis but ownCloud Web will redirect. |
micbar
force-pushed
the
wopi-driver-improvements
branch
2 times, most recently
from
0a5e2a7
to
5d9efbb
Compare
micbar
force-pushed
the
wopi-driver-improvements
branch
from
5d9efbb
to
9415263
Compare
kobergj
requested changes
Oct 4, 2022
kobergj
approved these changes
Oct 4, 2022
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The wopi app driver supports more options
We now generate a folderurl that is used in the wopi protocol to provide an endpoint to go back from the app to the containing folder in the file list. In addition to that we now inlclude the UI_LLCC parameter in the app open URL.
https://learn.microsoft.com/en-us/microsoft-365/cloud-storage-partner-program/online/discovery#ui_llcc