include spaces etags in virtual spaces #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
micbar
reviewed
Mar 9, 2022
internal/grpc/services/sharesstorageprovider/sharesstorageprovider.go
Outdated
Show resolved
Hide resolved
micbar
reviewed
Mar 9, 2022
internal/grpc/services/sharesstorageprovider/sharesstorageprovider.go
Outdated
Show resolved
Hide resolved
micbar
reviewed
Mar 9, 2022
internal/grpc/services/sharesstorageprovider/sharesstorageprovider.go
Outdated
Show resolved
Hide resolved
micbar
reviewed
Mar 9, 2022
internal/grpc/services/sharesstorageprovider/sharesstorageprovider.go
Outdated
Show resolved
Hide resolved
micbar
reviewed
Mar 9, 2022
micbar
reviewed
Mar 9, 2022
kobergj
reviewed
Mar 9, 2022
C0rby
force-pushed
the
etags-virtual-spaces
branch
from
806faa6
to
634002f
Compare
kobergj
approved these changes
Mar 14, 2022
22 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shares storage provider didn't include the etag in virtual spaces like the shares jail or mountpoints.