Reuse ocs role objects in other drivers #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #2521 |
gmgigi96
requested changes
Feb 8, 2022
There was a problem hiding this comment.
Hi @ishank011, I left some comments
Also you could fix this https://github.com/cs3org/reva/blob/master/internal/http/services/owncloud/ocs/conversions/role.go#L245 with the RoleUploader
ishank011
force-pushed
the
uniform-ocs-roles
branch
2 times, most recently
from
9c02d6b
to
d1cdc26
Compare
ishank011
force-pushed
the
uniform-ocs-roles
branch
from
d1cdc26
to
f21dfb5
Compare
ishank011
force-pushed
the
uniform-ocs-roles
branch
from
c27a51a
to
a8ec504
Compare
labkode
approved these changes
Apr 20, 2022
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.