Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Merge master into edge #2473

Merged
merged 61 commits into from
Jan 27, 2022
Merged
Show file tree
Hide file tree
Changes from 54 commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
939768a
[Build-deps] Additional rules for CODEOWNERS (#2323)
glpatcern Dec 3, 2021
ed9517b
Remove share refs from trashbin (#2298)
gmgigi96 Dec 6, 2021
147c0c2
Public link propfind (#2315)
Dec 6, 2021
7f7f9ec
fix public share type in propfinds (#2316)
Dec 7, 2021
d9eefe2
Bump core commit id for tests (#2331)
SwikritiT Dec 8, 2021
4dde766
Revert "Fix content disposition (#2303)" (#2332)
ishank011 Dec 9, 2021
8fde5db
[Build-deps]: Bump github.com/gomodule/redigo from 1.8.5 to 1.8.6 (#2…
dependabot[bot] Dec 9, 2021
e210912
[Build-deps]: Bump github.com/mitchellh/mapstructure from 1.4.2 to 1.…
dependabot[bot] Dec 9, 2021
66071c8
[Build-deps]: Bump github.com/aws/aws-sdk-go from 1.42.9 to 1.42.19 (…
dependabot[bot] Dec 9, 2021
68b64bf
fix app provider new file action and improve app provider error codes…
wkloucek Dec 9, 2021
2f727fc
Parse URL path to determine file name (#2346)
ishank011 Dec 9, 2021
d54df2f
v1.17.0
ishank011 Dec 9, 2021
778de37
handle non existent spaces gracefully (#2354)
micbar Dec 12, 2021
7e9eff3
Bump core commit id for tests (#2365)
SwikritiT Dec 13, 2021
30b629e
[Build-deps]: Bump github.com/minio/minio-go/v7 from 7.0.16 to 7.0.18…
dependabot[bot] Dec 13, 2021
2fae455
[Build-deps]: Bump github.com/ReneKroon/ttlcache/v2 from 2.9.0 to 2.1…
dependabot[bot] Dec 13, 2021
0771dfa
[Build-deps]: Bump go.opentelemetry.io/otel/exporters/jaeger (#2362)
dependabot[bot] Dec 13, 2021
8236ffa
fix tests by pointing to the right owncloud/core commit id for tests …
wkloucek Dec 15, 2021
f76d428
add new file capabilties to ocs for the app provider (#2379)
wkloucek Dec 15, 2021
8c6bad6
Remove test from expected to fail and bump commit id (#2380)
SwikritiT Dec 15, 2021
e65efdc
add .drone.env to CODEOWNERS as it is part of the test files (#2378)
phil-davis Dec 15, 2021
5cde018
fix webdav copy for zero byte files (#2374)
wkloucek Dec 15, 2021
f3c8b62
Implement touch file (#2369)
wkloucek Dec 17, 2021
7196229
Dummy implementation of the Lock CS3APIs (#2350)
wkloucek Dec 17, 2021
9c822d0
allow new file create with app provider on public links (#2385)
wkloucek Dec 20, 2021
cd9a6fb
Bump core commit id and use core master for tests (#2391)
phil-davis Dec 22, 2021
28ad25c
Add product to ocs Version struct (#2397)
kulmann Dec 24, 2021
e541601
bump core commit id for tests (#2404)
saw-jan Dec 30, 2021
f2f4d9d
[Build-deps]: Bump github.com/mattn/go-sqlite3 from 1.14.9 to 1.14.10…
dependabot[bot] Jan 5, 2022
66369ba
[Build-deps]: Bump github.com/minio/minio-go/v7 from 7.0.18 to 7.0.20…
dependabot[bot] Jan 5, 2022
cd9aa62
[Build-deps]: Bump github.com/rs/cors from 1.8.0 to 1.8.2 (#2399)
dependabot[bot] Jan 5, 2022
0fd4b06
[Build-deps]: Bump github.com/ReneKroon/ttlcache/v2 (#2387)
dependabot[bot] Jan 5, 2022
0e9cb7d
[Build-deps]: Bump go.opentelemetry.io/contrib/instrumentation/google…
dependabot[bot] Jan 5, 2022
b804b9b
[tests-only] format .drone.star (#2411)
wkloucek Jan 5, 2022
2f21d4d
update tus/tusd to version 1.8.0 (#2393)
wkloucek Jan 5, 2022
f953398
Fixes for apps in public shares, project spaces for EOS driver (#2371)
ishank011 Jan 5, 2022
0f9142a
[Build-deps]: Bump github.com/aws/aws-sdk-go from 1.42.19 to 1.42.27 …
dependabot[bot] Jan 5, 2022
fa1d1fc
[Build-deps]: Bump github.com/rs/zerolog from 1.26.0 to 1.26.1 (#2388)
dependabot[bot] Jan 5, 2022
cedc008
update owncloud core commit id (#2418)
kiranparajuli589 Jan 7, 2022
b563723
[Build-deps]: Bump github.com/mattn/go-sqlite3 (#2425)
dependabot[bot] Jan 10, 2022
3ac52f9
[Build-deps]: Bump github.com/gomodule/redigo from 1.8.6 to 1.8.8 (#2…
dependabot[bot] Jan 10, 2022
32b439e
OIDC and WOPI changes for lightweight users (#2278)
ishank011 Jan 12, 2022
65014d1
[tests-only]Bump the commit id for tests (#2441)
SwikritiT Jan 14, 2022
16a4df2
CephFS Reva v0.2 (#1209)
thmour Jan 17, 2022
81e8416
[Build-deps]: Bump github.com/minio/minio-go/v7 from 7.0.20 to 7.0.21…
dependabot[bot] Jan 17, 2022
9c814c6
[Build-deps]: Bump github.com/hashicorp/go-hclog from 1.0.0 to 1.1.0 …
dependabot[bot] Jan 17, 2022
7117894
[Build-deps]: Bump github.com/BurntSushi/toml from 0.4.1 to 1.0.0 (#2…
dependabot[bot] Jan 17, 2022
4cd33f0
revert go-sqlite downgrade (#2461)
wkloucek Jan 24, 2022
6f0ac6b
[Build-deps]: Bump github.com/google/go-cmp from 0.5.6 to 0.5.7 (#2466)
dependabot[bot] Jan 24, 2022
a649b7d
[Build-deps]: Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.39 …
dependabot[bot] Jan 24, 2022
fdad1a5
[Build-deps]: Bump github.com/ceph/go-ceph from 0.12.0 to 0.13.0 (#2468)
dependabot[bot] Jan 24, 2022
cf04a9f
[Build-deps]: Bump github.com/onsi/gomega from 1.17.0 to 1.18.0 (#2469)
dependabot[bot] Jan 24, 2022
393f831
Use permissions API in decomposedfs (#2341)
Jan 24, 2022
9ed5f32
[tests-only]Bump Core Commit Id (#2451)
amrita-shrestha Jan 25, 2022
0e8c017
Bump commit id for tests 2022-01-25 (#2474)
phil-davis Jan 26, 2022
23075fe
Merge branch 'master' into edge
Jan 25, 2022
b3f53a1
Bump commit id for issue-ocis-3030 (#2476)
amrita-shrestha Jan 26, 2022
b0325fe
Merge branch 'master' into merge-master
Jan 26, 2022
45d40a4
Merge branch 'edge' into merge-master
Jan 26, 2022
ac0f51d
fix test failures
Jan 26, 2022
0d53a05
fix integration tests
Jan 27, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .dockerignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
.github
changelog
docs
examples
grpc-tests
tests
tools
Expand Down
105 changes: 105 additions & 0 deletions .drone.star
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ def main(ctx):
litmusOcisOldWebdav(),
litmusOcisNewWebdav(),
litmusOcisSpacesDav(),
# virtual views don't work on edge at the moment
#virtualViews(),
] + ocisIntegrationTests(6) + s3ngIntegrationTests(12)

def buildAndPublishDocker():
Expand Down Expand Up @@ -228,6 +230,26 @@ def buildAndPublishDocker():
],
},
},
{
"name": "publish-docker-revad-ceph-latest",
"pull": "always",
"image": "plugins/docker",
"settings": {
"repo": "cs3org/revad",
"tags": "latest-ceph",
"dockerfile": "Dockerfile.revad-ceph",
"username": {
"from_secret": "dockerhub_username",
},
"password": {
"from_secret": "dockerhub_password",
},
"custom_dns": [
"128.142.17.5",
"128.142.16.5",
],
},
},
],
}

Expand Down Expand Up @@ -481,6 +503,84 @@ def release():
],
},
},
{
"name": "docker-revad-ceph-tag",
"pull": "always",
"image": "plugins/docker",
"settings": {
"repo": "cs3org/revad",
"tags": "${DRONE_TAG}-ceph",
"dockerfile": "Dockerfile.revad-ceph",
"username": {
"from_secret": "dockerhub_username",
},
"password": {
"from_secret": "dockerhub_password",
},
"custom_dns": [
"128.142.17.5",
"128.142.16.5",
],
},
},
],
"depends_on": ["changelog"],
}

def virtualViews():
return {
"kind": "pipeline",
"type": "docker",
"name": "virtual-views",
"platform": {
"os": "linux",
"arch": "amd64",
},
"trigger": {
"event": {
"include": [
"pull_request",
"tag",
],
},
},
"steps": [
makeStep("build-ci"),
{
"name": "revad-services",
"image": "registry.cern.ch/docker.io/library/golang:1.17",
"detach": True,
"commands": [
"cd /drone/src/tests/oc-integration-tests/drone/",
"/drone/src/cmd/revad/revad -c frontend-global.toml &",
"/drone/src/cmd/revad/revad -c gateway.toml &",
"/drone/src/cmd/revad/revad -c storage-home-ocis.toml &",
"/drone/src/cmd/revad/revad -c storage-local-1.toml &",
"/drone/src/cmd/revad/revad -c storage-local-2.toml &",
"/drone/src/cmd/revad/revad -c users.toml",
],
},
cloneOc10TestReposStep(),
{
"name": "oC10APIAcceptanceTestsOcisStorage",
"image": "registry.cern.ch/docker.io/owncloudci/php:7.4",
"commands": [
"cd /drone/src",
"make test-acceptance-api",
],
"environment": {
"PATH_TO_CORE": "/drone/src/tmp/testrunner",
"TEST_SERVER_URL": "http://revad-services:20180",
"OCIS_REVA_DATA_ROOT": "/drone/src/tmp/reva/data/",
"DELETE_USER_DATA_CMD": "rm -rf /drone/src/tmp/reva/data/nodes/root/* /drone/src/tmp/reva/data/nodes/*-*-*-* /drone/src/tmp/reva/data/blobs/*",
"STORAGE_DRIVER": "OCIS",
"SKELETON_DIR": "/drone/src/tmp/testing/data/apiSkeleton",
"TEST_REVA": "true",
"REGULAR_USER_PASSWORD": "relativity",
"SEND_SCENARIO_LINE_REFERENCES": "true",
"BEHAT_SUITE": "apiVirtualViews",
},
},
],
"depends_on": ["changelog"],
}
Expand Down Expand Up @@ -516,6 +616,7 @@ def litmusOcisOldWebdav():
"/drone/src/cmd/revad/revad -c storage-shares.toml &",
"/drone/src/cmd/revad/revad -c storage-publiclink.toml &",
"/drone/src/cmd/revad/revad -c shares.toml &",
"/drone/src/cmd/revad/revad -c permissions-ocis-ci.toml &",
"/drone/src/cmd/revad/revad -c users.toml",
],
},
Expand Down Expand Up @@ -571,6 +672,7 @@ def litmusOcisNewWebdav():
"/drone/src/cmd/revad/revad -c storage-shares.toml &",
"/drone/src/cmd/revad/revad -c storage-publiclink.toml &",
"/drone/src/cmd/revad/revad -c shares.toml &",
"/drone/src/cmd/revad/revad -c permissions-ocis-ci.toml &",
"/drone/src/cmd/revad/revad -c users.toml",
],
},
Expand Down Expand Up @@ -627,6 +729,7 @@ def litmusOcisSpacesDav():
"/drone/src/cmd/revad/revad -c storage-shares.toml &",
"/drone/src/cmd/revad/revad -c storage-publiclink.toml &",
"/drone/src/cmd/revad/revad -c shares.toml &",
"/drone/src/cmd/revad/revad -c permissions-ocis-ci.toml &",
"/drone/src/cmd/revad/revad -c users.toml",
],
},
Expand Down Expand Up @@ -695,6 +798,7 @@ def ocisIntegrationTests(parallelRuns, skipExceptParts = []):
"/drone/src/cmd/revad/revad -c machine-auth.toml &",
"/drone/src/cmd/revad/revad -c storage-users-ocis.toml &",
"/drone/src/cmd/revad/revad -c storage-publiclink.toml &",
"/drone/src/cmd/revad/revad -c permissions-ocis-ci.toml &",
"/drone/src/cmd/revad/revad -c ldap-users.toml",
],
},
Expand Down Expand Up @@ -771,6 +875,7 @@ def s3ngIntegrationTests(parallelRuns, skipExceptParts = []):
"/drone/src/cmd/revad/revad -c storage-publiclink.toml &",
"/drone/src/cmd/revad/revad -c storage-shares.toml &",
"/drone/src/cmd/revad/revad -c ldap-users.toml &",
"/drone/src/cmd/revad/revad -c permissions-ocis-ci.toml &",
"/drone/src/cmd/revad/revad -c machine-auth.toml",
],
},
Expand Down
52 changes: 52 additions & 0 deletions Dockerfile.revad-ceph
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
# Copyright 2018-2021 CERN
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# In applying this license, CERN does not waive the privileges and immunities
# granted to it by virtue of its status as an Intergovernmental Organization
# or submit itself to any jurisdiction.

FROM ceph/daemon-base

RUN dnf update -y && dnf install -y \
git \
gcc \
make \
libcephfs-devel \
librbd-devel \
librados-devel

ADD https://golang.org/dl/go1.16.4.linux-amd64.tar.gz \
go1.16.4.linux-amd64.tar.gz

RUN rm -rf /usr/local/go && \
tar -C /usr/local -xzf go1.16.4.linux-amd64.tar.gz && \
rm go1.16.4.linux-amd64.tar.gz

ENV PATH /go/bin:/usr/local/go/bin:$PATH
ENV GOPATH /go

WORKDIR /go/src/github/cs3org/reva
COPY . .
RUN mkdir -p /go/bin \
make build-revad-cephfs-docker && \
cp /go/src/github/cs3org/reva/cmd/revad/revad /usr/bin/revad

RUN cp -r examples/ceph /etc/

RUN mkdir -p /etc/revad/ && echo "" > /etc/revad/revad.toml

EXPOSE 9999 10000

ENTRYPOINT [ "/usr/bin/revad" ]
CMD [ "-c", "/etc/revad/revad.toml", "-p", "/var/run/revad.pid" ]
12 changes: 8 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,19 @@ off:
imports: off
`go env GOPATH`/bin/goimports -w tools pkg internal cmd

build: imports test-go-version
gofmt -s -w .
go build -ldflags ${BUILD_FLAGS} -o ./cmd/revad/revad ./cmd/revad
go build -ldflags ${BUILD_FLAGS} -o ./cmd/reva/reva ./cmd/reva
build: build-revad build-reva test-go-version

build-cephfs: build-revad-cephfs build-reva

tidy:
go mod tidy

build-revad: imports
go build -ldflags ${BUILD_FLAGS} -o ./cmd/revad/revad ./cmd/revad

build-revad-cephfs: imports
go build -ldflags ${BUILD_FLAGS} -tags ceph -o ./cmd/revad/revad ./cmd/revad

build-reva: imports
go build -ldflags ${BUILD_FLAGS} -o ./cmd/reva/reva ./cmd/reva

Expand Down Expand Up @@ -104,6 +106,8 @@ ci: build-ci test lint-ci
# to be run in Docker build
build-revad-docker: off
go build -ldflags ${BUILD_FLAGS} -o ./cmd/revad/revad ./cmd/revad
build-revad-cephfs-docker: off
go build -ldflags ${BUILD_FLAGS} -tags ceph -o ./cmd/revad/revad ./cmd/revad
build-reva-docker: off
go build -ldflags ${BUILD_FLAGS} -o ./cmd/reva/reva ./cmd/reva
clean:
Expand Down
3 changes: 3 additions & 0 deletions changelog/unreleased/cephfs-driver.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Enhancement: Reva CephFS module v0.2.1

https://github.com/cs3org/reva/pull/1209
5 changes: 5 additions & 0 deletions changelog/unreleased/cs3-permissions-service.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Enhancement: Use CS3 permissions API

Added calls to the CS3 permissions API to the decomposedfs in order to check the user permissions.

https://github.com/cs3org/reva/pull/2341
1 change: 1 addition & 0 deletions cmd/revad/runtime/loader.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import (
_ "github.com/cs3org/reva/pkg/ocm/invite/manager/loader"
_ "github.com/cs3org/reva/pkg/ocm/provider/authorizer/loader"
_ "github.com/cs3org/reva/pkg/ocm/share/manager/loader"
_ "github.com/cs3org/reva/pkg/permission/manager/loader"
_ "github.com/cs3org/reva/pkg/publicshare/manager/loader"
_ "github.com/cs3org/reva/pkg/rhttp/datatx/manager/loader"
_ "github.com/cs3org/reva/pkg/share/cache/loader"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
---
title: "cephfs"
linkTitle: "cephfs"
weight: 10
description: >
Configuration for the cephfs service
---

# _struct: config_

{{% dir name="root" type="string" default="/var/tmp/reva/" %}}
Path of root directory for user storage. [[Ref]](https://github.com/cs3org/reva/tree/master/pkg/storage/fs/cephfs/cephfs.go#L34)
{{< highlight toml >}}
[storage.fs.cephfs]
root = "/var/tmp/reva/"
{{< /highlight >}}
{{% /dir %}}

{{% dir name="share_folder" type="string" default="/MyShares" %}}
Path for storing share references. [[Ref]](https://github.com/cs3org/reva/tree/master/pkg/storage/fs/cephfs/cephfs.go#L35)
{{< highlight toml >}}
[storage.fs.cephfs]
share_folder = "/MyShares"
{{< /highlight >}}
{{% /dir %}}

3 changes: 3 additions & 0 deletions examples/ceph/ceph.conf
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[global]
fsid = '8aaa35c4-75dc-42e5-a812-cbc1cdfd3323'
mon_host = '[v2:188.184.96.178:3300/0,v1:188.184.96.178:6789/0] [v2:188.185.88.76:3300/0,v1:188.185.88.76:6789/0] [v2:188.185.126.6:3300/0,v1:188.185.126.6:6789/0]'
2 changes: 2 additions & 0 deletions examples/ceph/keyring
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[client.admin]
key = 'AQAu88Fg5iekGhAAeVP0Td05PuybytuRJgBRqA=='
20 changes: 12 additions & 8 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,23 @@ module github.com/cs3org/reva
require (
bou.ke/monkey v1.0.2
contrib.go.opencensus.io/exporter/prometheus v0.4.0
github.com/BurntSushi/toml v0.4.1
github.com/BurntSushi/toml v1.0.0
github.com/Masterminds/goutils v1.1.1 // indirect
github.com/Masterminds/semver v1.5.0 // indirect
github.com/Masterminds/sprig v2.22.0+incompatible
github.com/ReneKroon/ttlcache/v2 v2.11.0
github.com/asaskevich/govalidator v0.0.0-20210307081110-f21760c49a8d // indirect
github.com/aws/aws-sdk-go v1.42.27
github.com/aws/aws-sdk-go v1.42.39
github.com/beevik/etree v1.1.0
github.com/bluele/gcache v0.0.2
github.com/c-bata/go-prompt v0.2.5
github.com/ceph/go-ceph v0.13.0
github.com/cheggaaa/pb v1.0.29
github.com/coreos/go-oidc v2.2.1+incompatible
github.com/cs3org/cato v0.0.0-20200828125504-e418fc54dd5e
github.com/cs3org/go-cs3apis v0.0.0-20211214102047-7ce3134d7bf8
github.com/cs3org/go-cs3apis v0.0.0-20211214102128-4e8745ab1654
github.com/cubewise-code/go-mime v0.0.0-20200519001935-8c5762b177d8
github.com/dgraph-io/ristretto v0.1.0
github.com/eventials/go-tus v0.0.0-20200718001131-45c7ec8f5d59
github.com/gdexlab/go-render v1.0.1
github.com/go-chi/chi/v5 v5.0.7
Expand All @@ -28,25 +30,26 @@ require (
github.com/golang-jwt/jwt v3.2.2+incompatible
github.com/golang/protobuf v1.5.2
github.com/gomodule/redigo v1.8.8
github.com/google/go-cmp v0.5.6
github.com/google/go-cmp v0.5.7
github.com/google/go-github v17.0.0+incompatible
github.com/google/go-querystring v1.1.0 // indirect
github.com/google/uuid v1.3.0
github.com/grpc-ecosystem/go-grpc-middleware v1.3.0
github.com/hashicorp/go-hclog v1.0.0
github.com/hashicorp/go-hclog v1.1.0
github.com/hashicorp/go-plugin v1.4.3
github.com/huandu/xstrings v1.3.2 // indirect
github.com/imdario/mergo v0.3.12 // indirect
github.com/jedib0t/go-pretty v4.3.0+incompatible
github.com/juliangruber/go-intersect v1.1.0
github.com/mattn/go-sqlite3 v1.14.10
github.com/maxymania/go-system v0.0.0-20170110133659-647cc364bf0b
github.com/mileusna/useragent v1.0.2
github.com/minio/minio-go/v7 v7.0.20
github.com/minio/minio-go/v7 v7.0.21
github.com/mitchellh/copystructure v1.2.0 // indirect
github.com/mitchellh/go-testing-interface v1.14.1 // indirect
github.com/mitchellh/mapstructure v1.4.3
github.com/onsi/ginkgo v1.16.5
github.com/onsi/gomega v1.17.0
github.com/onsi/gomega v1.18.0
github.com/pkg/errors v0.9.1
github.com/pkg/xattr v0.4.4
github.com/pquerna/cachecontrol v0.1.0 // indirect
Expand All @@ -71,7 +74,8 @@ require (
go.opentelemetry.io/otel/trace v1.3.0
golang.org/x/crypto v0.0.0-20211215165025-cf75a172585e
golang.org/x/oauth2 v0.0.0-20211005180243-6b3c2da341f1
golang.org/x/sys v0.0.0-20211025201205-69cdffdb9359
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
golang.org/x/sys v0.0.0-20211216021012-1d35b9e2eb4e
golang.org/x/term v0.0.0-20210916214954-140adaaadfaf
google.golang.org/genproto v0.0.0-20211021150943-2b146023228c
google.golang.org/grpc v1.42.0
Expand Down
Loading