Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix open by default app and expose default app #2230

Merged
merged 2 commits into from
Nov 10, 2021
Merged

fix open by default app and expose default app #2230

merged 2 commits into from
Nov 10, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Nov 3, 2021

needs: cs3org/cs3apis#157

needed because of owncloud/web#5970 (comment)

After this PR the /app/list endpoint will provide a default app (if configured):

    {
      "mime_type": "application/vnd.oasis.opendocument.text",
      "ext": "odt",
      "app_providers": [
        {
          "name": "Collabora",
          "icon": "https://www.collaboraoffice.com/wp-content/uploads/2019/01/CP-icon.png"
        }
      ],
      "name": "OpenDocument",
      "description": "OpenDocument text document",
      "allow_creation": true,
      "default_application": "Collabora"
    }

glpatcern
glpatcern previously approved these changes Nov 4, 2021
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, clearly having the default semantically explicit is better than just relying on the sorting of the app providers, which was definitely temporary.

At this point we could actually remove the logic to keep the app providers list ordered.

@wkloucek
Copy link
Contributor Author

wkloucek commented Nov 4, 2021

@glpatcern I updated the CS3apis, can we get this in?

@glpatcern
Copy link
Member

(did not merge yet because I'm not code owner - will check with @ishank011 also to update the CODEOWNERS rules for those subtrees)

wkloucek added a commit to owncloud/ocis that referenced this pull request Nov 4, 2021
@ishank011 ishank011 merged commit 63cd968 into cs3org:master Nov 10, 2021
wkloucek added a commit to owncloud/ocis that referenced this pull request Nov 10, 2021
C0rby pushed a commit to owncloud/ocis that referenced this pull request Nov 10, 2021
kulmann added a commit to owncloud/ocis that referenced this pull request Nov 11, 2021
ownclouders pushed a commit to owncloud/ocis that referenced this pull request Nov 11, 2021
Merge: 45c3b07 719df3c
Author: Benedikt Kulmann <[email protected]>
Date:   Thu Nov 11 16:07:17 2021 +0100

    Merge pull request #2726 from owncloud/reva_default_app

    [full-ci] update reva to get cs3org/reva#2230
wkloucek added a commit to owncloud/ocis that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants