Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix etag propagation on deletes #1957

Merged
merged 1 commit into from
Aug 5, 2021
Merged

fix etag propagation on deletes #1957

merged 1 commit into from
Aug 5, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Aug 5, 2021

When deleting a file the etag propagation would skip the parent of the deleted file.

@C0rby C0rby requested a review from labkode as a code owner August 5, 2021 11:09
@C0rby C0rby self-assigned this Aug 5, 2021
phil-davis
phil-davis approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - simple change, lots of scenarios start passing, no regressions elsewhere.

@labkode labkode merged commit 1df14f7 into cs3org:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode labkode approved these changes

@phil-davis phil-davis phil-davis approved these changes

@butonic butonic Awaiting requested review from butonic

@refs refs Awaiting requested review from refs

@ishank011 ishank011 Awaiting requested review from ishank011

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@C0rby @phil-davis @labkode