-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the uploading files workflow from various clients #1285
Conversation
6ba75ef
to
44f1e3f
Compare
This pull request introduces 1 alert and fixes 6 when merging dbcbe85 into a84a1ee - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 6 when merging c03f4cc into a84a1ee - view on LGTM.com new alerts:
fixed alerts:
|
This pull request fixes 6 alerts when merging e1d32b8 into a84a1ee - view on LGTM.com fixed alerts:
|
e1d32b8
to
66cf4ea
Compare
This pull request fixes 6 alerts when merging 66cf4ea into a84a1ee - view on LGTM.com fixed alerts:
|
This pull request fixes 6 alerts when merging 2fb20d2 into a84a1ee - view on LGTM.com fixed alerts:
|
This pull request fixes 6 alerts when merging bb8bd98 into a84a1ee - view on LGTM.com fixed alerts:
|
This pull request fixes 6 alerts when merging e520f5c into a84a1ee - view on LGTM.com fixed alerts:
|
@individual-it for some reason the oc integration test are failing (almost all), can you take a look? |
e520f5c
to
cf62669
Compare
This pull request fixes 6 alerts when merging cf62669 into ce120f7 - view on LGTM.com fixed alerts:
|
Passing after a rebase. PR #1290 fixed that here in How to communicate that to everybody that codes in this repo? |
return | ||
} | ||
|
||
// check permissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you removed the permissions checks ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refactored the Upload method to work with the logic implemented in InitiateFileUpload, so that is taken care of there itself. I'm pushing a fix so that it works without calling that first as well.
No description provided.