Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the uploading files workflow from various clients #1285

Merged
merged 16 commits into from
Nov 5, 2020

Conversation

ishank011
Copy link
Contributor

No description provided.

@ishank011 ishank011 force-pushed the uploads-refactor branch 3 times, most recently from 6ba75ef to 44f1e3f Compare October 29, 2020 09:38
@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request introduces 1 alert and fixes 6 when merging dbcbe85 into a84a1ee - view on LGTM.com

new alerts:

  • 1 for Incorrect conversion between integer types

fixed alerts:

  • 5 for Uncontrolled data used in path expression
  • 1 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request introduces 1 alert and fixes 6 when merging c03f4cc into a84a1ee - view on LGTM.com

new alerts:

  • 1 for Incorrect conversion between integer types

fixed alerts:

  • 5 for Uncontrolled data used in path expression
  • 1 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 6 alerts when merging e1d32b8 into a84a1ee - view on LGTM.com

fixed alerts:

  • 5 for Uncontrolled data used in path expression
  • 1 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 6 alerts when merging 66cf4ea into a84a1ee - view on LGTM.com

fixed alerts:

  • 5 for Uncontrolled data used in path expression
  • 1 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 6 alerts when merging 2fb20d2 into a84a1ee - view on LGTM.com

fixed alerts:

  • 5 for Uncontrolled data used in path expression
  • 1 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 6 alerts when merging bb8bd98 into a84a1ee - view on LGTM.com

fixed alerts:

  • 5 for Uncontrolled data used in path expression
  • 1 for Incorrect conversion between integer types

@ishank011 ishank011 marked this pull request as ready for review October 30, 2020 19:04
@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2020

This pull request fixes 6 alerts when merging e520f5c into a84a1ee - view on LGTM.com

fixed alerts:

  • 5 for Uncontrolled data used in path expression
  • 1 for Incorrect conversion between integer types

@labkode
Copy link
Member

labkode commented Nov 2, 2020

@individual-it for some reason the oc integration test are failing (almost all), can you take a look?
Thanks

@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2020

This pull request fixes 6 alerts when merging cf62669 into ce120f7 - view on LGTM.com

fixed alerts:

  • 5 for Uncontrolled data used in path expression
  • 1 for Incorrect conversion between integer types

@phil-davis
Copy link
Contributor

Passing after a rebase.
PRs will need a rebase because the dependencies in the test infrastructure got broken due to PHP composer 2.0 update that happened in owncloud-ci/php docker today (somewhat accidentally, it was intended to just update the PHP patch release versions, but composer 2.0 came "for free" automagically). See issue owncloud/core#38067

PR #1290 fixed that here in cs3org/reva

How to communicate that to everybody that codes in this repo?

@labkode labkode merged commit cc7a289 into cs3org:master Nov 5, 2020
@ishank011 ishank011 deleted the uploads-refactor branch November 10, 2020 16:27
return
}

// check permissions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you removed the permissions checks ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactored the Upload method to work with the logic implemented in InitiateFileUpload, so that is taken care of there itself. I'm pushing a fix so that it works without calling that first as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants