Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM sharing fails when reva is configured to use users json file #3550

Closed
redblom opened this issue Dec 12, 2022 · 2 comments
Closed

OCM sharing fails when reva is configured to use users json file #3550

redblom opened this issue Dec 12, 2022 · 2 comments

Comments

@redblom
Copy link
Contributor

redblom commented Dec 12, 2022

#3526 introduces a new owner parameter format (opaqueId@webDAVHost) in the share request for the ocm share nextcloud driver. The ocmd shares service at the receiving end will try to parse this owner value into the user opaqueID and the webDAV host again.
But this is not implemented for the ocm share json driver. So when reva is configured to use the users json file sharing fails 'in panic' due to an index out of range error.

@redblom
Copy link
Contributor Author

redblom commented Dec 12, 2022

So basically changing:

"owner": userID.OpaqueId,

into:
"owner": fmt.Sprintf("%s@%s", userID.OpaqueId, userID.Idp),

as stated here:

"meshProvider": userID.Idp, // FIXME: move this into the 'owner' string?

should do the trick.

redblom pushed a commit to redblom/reva that referenced this issue Dec 12, 2022
@redblom
Copy link
Contributor Author

redblom commented Dec 12, 2022

Fixed with #3551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant