Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM: required changes to comply with the invitation workflow #3540

Closed
glpatcern opened this issue Dec 9, 2022 · 0 comments · Fixed by #3611
Closed

OCM: required changes to comply with the invitation workflow #3540

glpatcern opened this issue Dec 9, 2022 · 0 comments · Fixed by #3611
Assignees

Comments

@glpatcern
Copy link
Member

Now that cs3org/OCM-API#54 was merged, and following the discussion with @michielbdejong and @labkode, we need to implement the following in Reva:

  • create a /sciencemesh route so that the current endpoint to generate an invite goes into /sciencemesh/generate-invite
  • /ocm/invites/forward to be renamed to /sciencemesh/accept-invite and the response to include the sender's identity details (similar format as the payload that contains the receiver's identity details)
  • /ocm/invites/accept to be renamed to /ocm/invite-accepted
  • when creating a new OCM share, consider the protocols parameter as an array with values ['webdav', 'webapp']. The latter would have a browsable URL as payload to be returned, which is expected to work like a public link.

More details to be spelled out once we get into the code.

gmgigi96 added a commit that referenced this issue Jan 24, 2023
* Refactored OCM Invite manager
* Updated /invite-accepted endpoint to the last OCM APIs spec (OCM-API#54)
   * Introduced mutual exchange of user information on invitation accept
* Add errors as specified by the OCM and cs3apis specs (OCM-API#58, cs3apis#198)
* Allow user to specify a description when generating an invitation token
* Split old ocmd http service in two services (OCM and sciencemesh)
* OCM: required changes to comply with the invitation workflow #3540
    * ocm services contain only the implementation of the OCM APIs (https://cs3org.github.io/OCM-API/docs.html)
    * sciencemesh is meant for reva clients (like web) for interacting with tokens and shares in OCM
* Written integration tests for the invitation workflow (both grpc and http)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants