Skip to content

Commit

Permalink
Replaced oldfind with newfind command
Browse files Browse the repository at this point in the history
  • Loading branch information
Jesse Geens committed Oct 14, 2024
1 parent 716e6b8 commit 9432334
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions changelog/unreleased/eos-newfind.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Enhancement: use newfind command in EOS

The EOS binary storage driver was still using EOS's oldfind command, which is deprecated. We now moved to the new find command, for which an extra flag (--skip-version-dirs) is needed.

https://github.com/cs3org/reva/pull/4883
2 changes: 1 addition & 1 deletion pkg/eosclient/eosbinary/eosbinary.go
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ func (c *Client) Rename(ctx context.Context, auth eosclient.Authorization, oldPa

// List the contents of the directory given by path.
func (c *Client) List(ctx context.Context, auth eosclient.Authorization, path string) ([]*eosclient.FileInfo, error) {
args := []string{"oldfind", "--fileinfo", "--maxdepth", "1", path}
args := []string{"newfind", "--fileinfo", "--skip-version-dirs", "--maxdepth", "1", path}
stdout, _, err := c.executeEOS(ctx, args, auth)
if err != nil {
return nil, errors.Wrapf(err, "eosclient: error listing fn=%s", path)
Expand Down

0 comments on commit 9432334

Please sign in to comment.