Align OCM sharing APIs to new specs, add missing properties #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmgigi96
force-pushed
the
ocm_specs
branch
2 times, most recently
from
3264061
to
0198ed5
Compare
glpatcern
changed the title
glpatcern
reviewed
Feb 6, 2023
|
@glpatcern done, can you take a look? |
labkode
approved these changes
Feb 6, 2023
dragonchaser
pushed a commit
to dragonchaser/cs3apis
that referenced
this pull request
Sep 1, 2023
* rework of ocm in cs3apis * defined ocm protocols * add opaque to protocols * add protocol fields to ocm share * splitted created share to received share * updated proto.lock * updated proto.lock * fixes for review * revert position of resource_id field in share message * update proto.lock * updated docs --------- Co-authored-by: Giuseppe Lo Presti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the OCM implementation according to the changes introduced in the OCM APIs cs3org/OCM-API#54 and cs3org/OCM-API#57.
Since the metadata associated with an OCM share is different between local and remote provider (and the information every site has to store), there is now a clear distinction between the object
Share(the one created locally) and theReceivedShare(the one received from the remote site).More in details, these are the changes including the breaking changes:
OCMCoreShareRequest (remote share):
webdav,webappandtransfer), instead of a single protocol [breaking change]provider_idis renamed toresource_id[breaking change]sender[breaking change]resource_type, andshare_type(previously missing but part of OCM. Behavior remains the same)expirationtimeOCMShareRequest (local share sent to a remote grantee):
grant(includedpermissionsandgrantee), replaced with justgrantee[breaking change]permissionsas that's incorporated in theaccess_methodstoken, free string [breaking change]. So far we reused the user's token with full power (insecure!), this is the scoped token for the resource with configurable expiration.share_type(previously missing but part of OCM. Behavior remains the same)share_typeto tell apart Datatx (i.e.transfer) shares from others [breaking change], as this is now captured by the list of protocols / access methods directly.expirationtimeReceivedShare (internal structure to represent a share received from a remote granter)