Changed tokens to be handled externally, CI fixes, and fixed package structure. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
examples/file_api_example.py
Dismissed
| if res is not None: | ||
| print(res) | ||
|
|
||
| # touchfile | ||
| touch_resource = Resource.from_file_ref_and_endpoint("/eos/user/r/rwelande/touch_file.txt") | ||
| text_resource = Resource.from_file_ref_and_endpoint("/eos/user/r/rwelande/text_file.txt") | ||
| res = client.file.touch_file(touch_resource) | ||
| res = client.file.touch_file(text_resource) | ||
| res = client.file.touch_file(client.auth.get_token(), touch_resource) |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning
There was a problem hiding this comment.
This code is an example and can be ignored.
examples/file_api_example.py
Dismissed
|
|
||
| if res is not None: | ||
| print(res) | ||
|
|
||
| res = client.file.touch_file(touch_resource) | ||
| res = client.file.touch_file(client.auth.get_token(), touch_resource) |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning
There was a problem hiding this comment.
This code is an example and can be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tokens are now handled externally to allow parallelism (makes the package stateless) which allows to user to reuse the connection in multiple threads. Methods for handling token operations (check_token, get_token) are still available and public to the user.
The CI has also been updated to build the package and install it using pip and the package structure has been corrected because of this. The unit tests now use the package that is installed instead of importing directly from the .py files, changes in the source code has also been made to reflect this change. This change is important because it tests that the package works as it should as a package.