Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update revad version and entrypoint #27

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

SamuAlfageme
Copy link
Contributor

@SamuAlfageme SamuAlfageme commented Jun 16, 2021

Draft until cs3org/reva#1797 is merged and v1.9.0 is released

Contributing a Chart / update to an existing Chart

  • Run helm lint on the chart dir.
  • (Update) Bump the Chart.yaml version before merging, to release it as a new version.
  • (Update) If the PR includes new configurable parameters in the chart's values.yaml. Add documentation in the appropiate README.

@SamuAlfageme SamuAlfageme changed the title Update version and entrypoint Update revad version and entrypoint Jun 16, 2021
Copy link
Collaborator

@Daniel-WWU-IT Daniel-WWU-IT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Not sure why the checks are failing...

@SamuAlfageme SamuAlfageme marked this pull request as ready for review July 1, 2021 08:35
@Daniel-WWU-IT
Copy link
Collaborator

@SamuAlfageme Do you have an idea why the check is failing? Otherwise, I'd just merge this PR, as the charts are really lacking behind by now...

@SamuAlfageme
Copy link
Contributor Author

@Daniel-WWU-IT it appears CI install step is failing due to some unrelated issues (most likely on helm/kind-action). Agreed, I'll merge it as is and fix that later.

@SamuAlfageme SamuAlfageme merged commit cd2f015 into cs3org:master Jul 1, 2021
@SamuAlfageme SamuAlfageme deleted the revad_switch_entrypoint branch July 1, 2021 10:59
@SamuAlfageme
Copy link
Contributor Author

Here's the issue just for reference: helm/kind-action#42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants