Fix 28 gcc output parse error

[neelabhg]

Fix #28:

1. Modified gcc output parser to output an error for the case mentioned in the issue.
2. Updated/fixed the linker test in the parser spec:
   The test expected one error. However, it should have expected two errors, but the parser returned only one because the gcc output string used a file name other than program.c. If the test were updated to use program.c, the test would have broken. Now, after updating the parser regex to take into account file names other than program.c, the test broke. So, I fixed the test to expect two errors and modified the test input to use program.c anyway.
3. Just as a fallback, if the compilation fails but the parser fails to return any errors, the error label shows a generic message instead of the error/warning count. Previously, the error label was empty, so the user couldn't click on it to reveal the gcc output window.
4. index.html cleanup

[neelabhg]

@scowalt Can you review this? Especially the change in the parser regex and the parser unit tests.
I'm merging this in because it "works", but I want you to provide feedback anyway.

[scowalt]

These changes look fine to me. I'm unsure of why 'error' is the expected error type in line 61 of the testing file, but everything else looks good.

[neelabhg]

Because the error text is "undefined reference", which should be an error.
Currently for that input the parser cannot figure out the error type, and outputs (.text+0x20) as the error type (which is actually the location of the error, just not in col:row format).

[angrave]

Sanity check:

Is the UI also more reasonable/obvious for link errors (e.g. errors that
do not have a specific line number)?
e.g.

int f();
int main() { f(); return 0;}

or worse, let's choose a function that's part of C stdio but give it a
different signature :-)

int puts();
int main() { puts(); return 0;}

Another example... (if -pthread gcc option is not defined...)

#include <pthread.h>
int main() { pthread_join(( |pthread_t )|0,NULL); return 0;}

Another example = empty source file!

Another example: Causing errors in an include file

#define int abc
#include <stdio.h>

Best,
Lawrence.

On 11/29/14 2:37 PM, Scott Walters wrote:

These changes look fine to me. I'm unsure of why 'error' is the
expected error type in line 61 of the testing file, but everything
else looks good.

—
Reply to this email directly or view it on GitHub
#54 (comment).