-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Captions on lesson videos #71
Comments
Changed all instances of "subtitles" to "captions" per this source Some implementation details:
Code should also have fault tolerance, so that a video will still play if its captions cannot be found or loaded. Loading these captions from sysassets will require cross-domain requests to be enabled on sysassets, as describe in #70 |
An isolated (but working) prototype of this exists in this repository. One thing this implementation does well is show the previous and upcoming lines along with the current caption. This helps put the material into better context, which will be especially important when users search for terms and potentially start in the middle of videos. Before much more progress can be made on this issue, the transcripts need to be added to the sysassets project in the WebVTT format. This is a work in progress. |
UPDATE: UPDATE2: So the method I mentioned before is the correct way to go. Apparently it is poorly document because it is a relatively new addition to videojs. See #85. |
An issue I'm running into now is that getting a remote track with videojs doesn't work with xdomain. (the videojs library expects CORS headers) I believe this is caused by the fact that videojs implements its own http request module. I may need to make a pull request on videojs or xdomain to fix this issue. I hope that we won't have to use a custom build of either library or do a complicated hack. |
The issue I described in my previous comment has magically disappeared. The completion of this issue is currently blocked by an issue with sysassets (EDIT: To clarify, even though completion of this issue is blocked by the sysassets issue, I will still be able to make significant progress using my personal fork of sysassets) |
On 4/1/15 3:36 PM, Scott Walters wrote:
|
Actually I don't think that was the cause. Basically, my issue was that the request for the remote caption track (made by videojs) wasn't being routed through xdomain. Thus, I was getting the CORS errors that led us to use xdomain in the first place. However, today I went to reproduce the error, and this issue was no longer present. The request for the transcripts is now being routed through xdomain as expected. In both of these instances I was/am testing using my personal fork of sysassets, at http://scowalt.github.io/sysassets, so I don't think the domain switch of sysassets was the cause. UPDATE: It appears that I'm still getting CORS issues on Chrome, but am not getting CORS issues on Firefox. More investigation to come |
I did a bit of research on using videojs-caption as a library to help with moving the subtitles out of the video player. However, using this library would require us to modify our subtitles out of the WebVTT format and into something less universal. |
If you haven't already, you could ask Bob(jren4) how he implemented the subtitles on the system programming videos at http://classtranscribe.com |
Load captions available in sysassets and show them as the lesson video is playing.
More information to come.
The text was updated successfully, but these errors were encountered: