Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visiting/refreshing the playground page causes lessons tab to disappear #57

Closed
neelabhg opened this issue Dec 2, 2014 · 4 comments · Fixed by #59
Closed

Visiting/refreshing the playground page causes lessons tab to disappear #57

neelabhg opened this issue Dec 2, 2014 · 4 comments · Fixed by #59
Assignees
Labels

Comments

@neelabhg
Copy link
Member

neelabhg commented Dec 2, 2014

When on the playground not as part of any lesson (url hash is #playground), and the lessons tab is present in the navigation bar, refreshing the page causes the lessons tab to disappear.
The same also happens when visiting the playground directly (by going to host/#playground)
This does not happen when on the playground as part of a lesson sequence (url hash is, for example, #chapter/0/section/1/activity/1).

The lessons tab is only shown when lessons are available. When visiting the playground directly, lessons are not fetched which is why the lessons tab is not shown. So the solution is to fetch lessons when visiting the playground, or to find another way of letting the user know that lessons are available.

@neelabhg neelabhg added the bug label Dec 2, 2014
@scowalt
Copy link
Contributor

scowalt commented Dec 6, 2014

I'm looking into resolving this bug. I'm able to reproduce the bug itself on my local sys-build project. (i.e. running grunt serve and going to the webpage doesn't show the tabs in the navigation bar). However, just using the local sys-build project I'm not able to reproduce a case where the tabs are shown.

I am able to reproduce the error and the correct case in the staging environment (http://cs-education.github.io/sys-staging/#playground). My instinct says that I should put my local sys-build into a local clone of the staging project ('sys-staging') in order to reproduce both of the cases you described above. Do you think this is the proper direction to go? If so, how do I include the build sys-build project in my local sys-staging project and run the local sys-staging environment?

@neelabhg
Copy link
Member Author

neelabhg commented Dec 6, 2014

@scowalt Sorry, completely forgot to give you a heads up on this. Due to cross-domain issues, currently we include some files from sysassets directly into sysbuild. Without these files, the man pages won't work, and lessons won't be downloaded, so the tabs won't be shown. This is fine for development, as we are almost always working on the playground. But when deploying, and in cases like this, having those sysassets files is important. The sysassets repository is huge, so downloading it as a dependency will make setting up sysbuild very time-consuming.

So, I've emailed you a zip file containing the relevant files needed. Expand the zip file into app/sysassets. So, for example, you should have a file app/sysassets/sys.min.json, among others.

I'll be working to find a way to get around the cross-domain issues so that we can make requests directly to the sysassets domain, or somehow have an automated process which downloads the relevant files without checking out the entire repository.

@neelabhg neelabhg added this to the UIUC senior project Fall 2014 milestone Dec 6, 2014
@angrave
Copy link
Contributor

angrave commented Dec 6, 2014

I'll look out for your email
We should talk face-to-face .. maybe after your last exam?
Best,
Lawrence.

On 12/6/14 1:31 AM, Neelabh Gupta wrote:

Sorry, completely forgot to give you a heads up on this. Due to
cross-domain issues, currently we include some files from sysassets
https://github.com/angrave/sysassets directly into sysbuild. Without
these files, the man pages won't work, and lessons won't be
downloaded, so the tabs won't be shown. This is fine for development,
as we are almost always working on the playground. But when deploying,
and in cases like this, having those sysassets files is important. The
sysassets repository is huge, so downloading it a dependency will make
setting up sysbuild very time-consuming.

So, I've emailed you a zip file containing the relevant files needed.
Expand the zip file into |app/sysassets|. So, for example, you should
have a file |app/sysassets/sys.min.json|, among others.

I'll be working to find a way to get around the cross-domain issues so
that we can make requests directly to the sysassets domain, or somehow
have an automated process which downloads the relevant files without
checking out the entire repository.


Reply to this email directly or view it on GitHub
#57 (comment).

@scowalt
Copy link
Contributor

scowalt commented Dec 6, 2014

@neelabhg Thanks for the info. I've received the file and will continue my work with these assets
@angrave I've emailed you regarding a team meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants