Improve transient storage support #2588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
state_variables_ordered
: All state variables including constants and immutables. Same as beforestorage_variables_ordered
: Only state variables with storage locationtransient_variables_ordered
: Only state variables with transient locationstored_state_variables
as it adds complexity to the API, it's enough the ordered version independently if the order matters or not,is_stored
property to theStateVariable
class from theVariable
class as it only makes sense forStateVariable
, all the code was already using it after checking if the var is aStateVariable
. Added theis_transient
equivalent.