-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile: fix ckzg
build
#2494
Conversation
Building `ckzg` requires `make` to be present.
WalkthroughWalkthroughThe Dockerfile is modified to include the installation of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (5)
Dockerfile (5)
Line range hint
13-13
: Consider using aWORKDIR
directive.Instead of using
cd
to change directories, it's recommended to use theWORKDIR
directive for better readability and reliability in Dockerfiles.- RUN cd /slither && \ + WORKDIR /slither + RUN \Tools
Hadolint
[warning] 3-3: Pin versions in apt get install. Instead of
apt-get install <package>
useapt-get install <package>=<version>
(DL3008)
Line range hint
13-13
: Pin versions in pip installs.To avoid potential issues with package updates, it's advisable to pin the versions of packages installed via pip.
- pip3 install --no-cache-dir --upgrade pip && \ + pip3 install --no-cache-dir pip==21.0.1 && \Tools
Hadolint
[warning] 3-3: Pin versions in apt get install. Instead of
apt-get install <package>
useapt-get install <package>=<version>
(DL3008)
Line range hint
23-23
: Correct the syntax for Docker labels.The label key should be in a valid format according to Docker's best practices.
- LABEL src="https://github.com/trailofbits/slither" + LABEL org.opencontainers.image.source="https://github.com/trailofbits/slither"Tools
Hadolint
[warning] 3-3: Pin versions in apt get install. Instead of
apt-get install <package>
useapt-get install <package>=<version>
(DL3008)
Line range hint
26-26
: Pin versions of packages installed with apt-get.To ensure stability and security, it is recommended to pin the versions of all packages installed via apt-get.
- && apt-get install -y --no-install-recommends python3-pip \ + && apt-get install -y --no-install-recommends python3-pip=20.3.4-1ubuntu1 \Also applies to: 33-33
Tools
Hadolint
[warning] 3-3: Pin versions in apt get install. Instead of
apt-get install <package>
useapt-get install <package>=<version>
(DL3008)
Line range hint
53-53
: Use JSON notation for CMD.For clarity and to avoid shell form side effects, it's recommended to use JSON array notation for CMD.
- CMD /bin/bash + CMD ["/bin/bash"]Tools
Hadolint
[warning] 3-3: Pin versions in apt get install. Instead of
apt-get install <package>
useapt-get install <package>=<version>
(DL3008)
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- Dockerfile (1 hunks)
Additional context used
Hadolint
Dockerfile
[warning] 3-3: Pin versions in apt get install. Instead of
apt-get install <package>
useapt-get install <package>=<version>
(DL3008)
[warning] 13-13: Use WORKDIR to switch to a directory (DL3003)
[warning] 13-13: Pin versions in pip. Instead of
pip install <package>
usepip install <package>==<version>
orpip install --requirement <requirements file>
(DL3013)
[style] 23-23: Invalid label key. (DL3048)
[warning] 26-26: Pin versions in apt get install. Instead of
apt-get install <package>
useapt-get install <package>=<version>
(DL3008)
[warning] 33-33: Pin versions in apt get install. Instead of
apt-get install <package>
useapt-get install <package>=<version>
(DL3008)
[warning] 53-53: Use arguments JSON notation for CMD and ENTRYPOINT arguments (DL3025)
@@ -3,6 +3,7 @@ FROM ubuntu:jammy AS python-wheels | |||
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \ | |||
gcc \ | |||
git \ | |||
make \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pin the version of make
.
To ensure reproducibility and avoid potential future compatibility issues, it's recommended to pin the version of the make
package.
- make \
+ make=4.3-4.1build1 \
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
make \ | |
make=4.3-4.1build1 \ |
Building
ckzg
requiresmake
to be present.Summary by CodeRabbit
make
package installation in the Dockerfile to enhance build processes.