Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: fix ckzg build #2494

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Dockerfile: fix ckzg build #2494

merged 1 commit into from
Jun 25, 2024

Conversation

elopez
Copy link
Member

@elopez elopez commented Jun 24, 2024

Building ckzg requires make to be present.

Summary by CodeRabbit

  • Chores
    • Added the make package installation in the Dockerfile to enhance build processes.

Building `ckzg` requires `make` to be present.
Copy link

coderabbitai bot commented Jun 24, 2024

Walkthrough

Walkthrough

The Dockerfile is modified to include the installation of the make package in the python-wheels stage. This change enhances the build process by ensuring all required build tools are available within this stage, potentially streamlining future builds and dependency installations.

Changes

File Change Summary
Dockerfile Added the make package installation in the python-wheels stage.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@elopez elopez marked this pull request as ready for review June 24, 2024 16:42
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (5)
Dockerfile (5)

Line range hint 13-13: Consider using a WORKDIR directive.

Instead of using cd to change directories, it's recommended to use the WORKDIR directive for better readability and reliability in Dockerfiles.

- RUN cd /slither && \
+ WORKDIR /slither
+ RUN \
Tools
Hadolint

[warning] 3-3: Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version> (DL3008)


Line range hint 13-13: Pin versions in pip installs.

To avoid potential issues with package updates, it's advisable to pin the versions of packages installed via pip.

-    pip3 install --no-cache-dir --upgrade pip && \
+    pip3 install --no-cache-dir pip==21.0.1 && \
Tools
Hadolint

[warning] 3-3: Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version> (DL3008)


Line range hint 23-23: Correct the syntax for Docker labels.

The label key should be in a valid format according to Docker's best practices.

- LABEL src="https://github.com/trailofbits/slither"
+ LABEL org.opencontainers.image.source="https://github.com/trailofbits/slither"
Tools
Hadolint

[warning] 3-3: Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version> (DL3008)


Line range hint 26-26: Pin versions of packages installed with apt-get.

To ensure stability and security, it is recommended to pin the versions of all packages installed via apt-get.

-  && apt-get install -y --no-install-recommends python3-pip \
+  && apt-get install -y --no-install-recommends python3-pip=20.3.4-1ubuntu1 \

Also applies to: 33-33

Tools
Hadolint

[warning] 3-3: Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version> (DL3008)


Line range hint 53-53: Use JSON notation for CMD.

For clarity and to avoid shell form side effects, it's recommended to use JSON array notation for CMD.

- CMD /bin/bash
+ CMD ["/bin/bash"]
Tools
Hadolint

[warning] 3-3: Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version> (DL3008)

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a39dcbb and 072a64b.

Files selected for processing (1)
  • Dockerfile (1 hunks)
Additional context used
Hadolint
Dockerfile

[warning] 3-3: Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version> (DL3008)


[warning] 13-13: Use WORKDIR to switch to a directory (DL3003)


[warning] 13-13: Pin versions in pip. Instead of pip install <package> use pip install <package>==<version> or pip install --requirement <requirements file> (DL3013)


[style] 23-23: Invalid label key. (DL3048)


[warning] 26-26: Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version> (DL3008)


[warning] 33-33: Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version> (DL3008)


[warning] 53-53: Use arguments JSON notation for CMD and ENTRYPOINT arguments (DL3025)

@@ -3,6 +3,7 @@ FROM ubuntu:jammy AS python-wheels
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
gcc \
git \
make \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin the version of make.

To ensure reproducibility and avoid potential future compatibility issues, it's recommended to pin the version of the make package.

-    make \
+    make=4.3-4.1build1 \
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
make \
make=4.3-4.1build1 \

@0xalpharush 0xalpharush merged commit 84e8633 into dev Jun 25, 2024
79 checks passed
@0xalpharush 0xalpharush deleted the dev-docker-ckzg branch June 25, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants