Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync dev <> master #2493

Merged
merged 6 commits into from
Jun 24, 2024
+10 −5
Merged

sync dev <> master #2493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c6db465
chore: recommend upgrading in issue template
0xalpharush May 10, 2024
1a50b8e
Merge pull request #2457 from crytic/0xalpharush-patch-1
0xalpharush May 10, 2024
353d4da
Merge pull request #2475 from crytic/dev
0xalpharush Jun 5, 2024
900fda7
fix: sort by impact
0xalpharush Jun 5, 2024
2e6508f
fix: do not report libraries as dead code
0xalpharush Jun 5, 2024
798c1f6
Merge pull request #2476 from crytic/fixups
0xalpharush Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@ body:
-
attributes:
value: |
Please check the issues tab to avoid duplicates.
Please check the issues tab to avoid duplicates, and
confirm that the bug exists on the latest release (upgrade
by running `python3 -m pip install --upgrade slither-analyzer`).

If you are having difficulty installing slither,
please head over to the "Discussions" page.

Thanks for taking the time to fill out this bug report!
type: markdown
-
Expand All @@ -17,7 +21,7 @@ body:
required: true
-
attributes:
description: "It can be a github repo, etherscan link, or code snippet."
description: "It can be a github repo (preferred), etherscan link, or code snippet."
label: "Code example to reproduce the issue:"
placeholder: "`contract A {}`\n"
id: reproduce
Expand All @@ -27,7 +31,7 @@ body:
-
attributes:
description: |
What version of slither are you running?
What version of slither are you running?
Run `slither --version`
label: "Version:"
id: version
Expand Down
2 changes: 1 addition & 1 deletion slither/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ def choose_detectors(
set(detectors_to_run), args.detectors_to_include, detectors
)

detectors_to_run = sorted(detectors_to_run, key=lambda x: x.IMPACT)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor the sorting logic for clarity and efficiency.

Sorting detectors_to_run by the IMPACT attribute enhances the execution order of detectors based on their importance, which is a crucial improvement for performance and prioritization. However, consider using a more explicit attribute for sorting, such as IMPACT_PRIORITY, to make the purpose of the sorting clearer and to avoid potential confusion with the impact level (e.g., severity).

-    detectors_to_run = sorted(detectors_to_run, key=lambda x: x.IMPACT)
+    detectors_to_run = sorted(detectors_to_run, key=lambda x: x.IMPACT_PRIORITY)
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
detectors_to_run = sorted(detectors_to_run, key=lambda x: x.IMPACT)
detectors_to_run = sorted(detectors_to_run, key=lambda x: x.IMPACT_PRIORITY)

return detectors_to_run


Expand All @@ -255,7 +256,6 @@ def __include_detectors(
else:
raise ValueError(f"Error: {detector} is not a detector")

detectors_to_run = sorted(detectors_to_run, key=lambda x: x.IMPACT)
return detectors_to_run


Expand Down
3 changes: 2 additions & 1 deletion slither/detectors/functions/dead_code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,10 @@ def _detect(self) -> List[Output]:
continue
if isinstance(function, FunctionContract) and (
function.contract_declarer.is_from_dependency()
or function.contract_declarer.is_library
):
continue
# Continue if the functon is not implemented because it means the contract is abstract
# Continue if the function is not implemented because it means the contract is abstract
if not function.is_implemented:
continue
info: DETECTOR_INFO = [function, " is never used and should be removed\n"]
Expand Down
Loading