Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos and link update #2453

Merged
merged 1 commit into from
May 5, 2024
Merged

Conversation

xiaoxianBoy
Copy link
Contributor

@xiaoxianBoy xiaoxianBoy commented May 4, 2024

fix some typos and link update

Summary by CodeRabbit

  • Documentation

    • Updated external documentation links from beta.openai.com to platform.openai.com.
  • Bug Fixes

    • Corrected typos in various code comments to improve clarity and accuracy.

Copy link

coderabbitai bot commented May 4, 2024

Walkthrough

The recent updates primarily focus on correcting typographical errors in comments and updating URLs across various documentation and code files in the Slither project. These refinements enhance clarity and ensure that external links point to the correct OpenAI platform.

Changes

File Path Change Summary
.../documentation/README.md Updated URLs from beta.openai.com to platform.openai.com
.../expression/read_var.py Corrected typos in comments related to assignment operations
.../slithir/expression_to_slithir.py Fixed typo in comment from assigment to assignment
.../vyper_parsing/declarations/contract.py Corrected typo in comment from "compilatuion" to "compilation"

🐇✨
A hop, skip, and a jump,
From codex links now plump.
Typos caught, with care they're fixed,
Cleaner code, no more tricks!
A rabbit's cheer for code so slick! 🎉
🐇✨


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between fdf54f6 and 0dca6a6.
Files selected for processing (4)
  • slither/tools/documentation/README.md (1 hunks)
  • slither/visitors/expression/read_var.py (1 hunks)
  • slither/visitors/slithir/expression_to_slithir.py (1 hunks)
  • slither/vyper_parsing/declarations/contract.py (1 hunks)
Files skipped from review due to trivial changes (2)
  • slither/visitors/expression/read_var.py
  • slither/vyper_parsing/declarations/contract.py
Additional Context Used
LanguageTool (4)
slither/tools/documentation/README.md (4)

Near line 3: This sentence does not start with an uppercase letter.
Context: ...-documentation slither-documentation uses codex to...


Near line 3: Possible spelling mistake found.
Context: ...ttps://platform.openai.com) to generate natspec documenation. This tool is experimenta...


Near line 3: Possible spelling mistake found.
Context: ...latform.openai.com) to generate natspec documenation. This tool is experimental. See [solma...


Near line 5: Possible spelling mistake found.
Context: ...ation. This tool is experimental. See [solmate documentation](https://github.com/monty...

Ruff (2)
slither/visitors/slithir/expression_to_slithir.py (2)

195-195: Test for object identity should be is not


211-211: Test for object identity should be is not


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Out of diff range and nitpick comments (2)
slither/visitors/slithir/expression_to_slithir.py (2)

Line range hint 195-195: Use is not for object identity tests to adhere to Python best practices.

-                        not left[idx] is None
+                        left[idx] is not None

Line range hint 211-211: Use is not for object identity tests to adhere to Python best practices.

-                    if not left[idx] is None:
+                    if left[idx] is not None:

@@ -1,5 +1,5 @@
# slither-documentation

`slither-documentation` uses [codex](https://beta.openai.com) to generate natspec documenation.
`slither-documentation` uses [codex](https://platform.openai.com) to generate natspec documenation.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize the first letter of the sentence for consistency and professionalism.

- `slither-documentation` uses [codex](https://platform.openai.com) to generate natspec documenation.
+ `Slither-documentation` uses [codex](https://platform.openai.com) to generate natspec documentation.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
`slither-documentation` uses [codex](https://platform.openai.com) to generate natspec documenation.
`Slither-documentation` uses [codex](https://platform.openai.com) to generate natspec documentation.

Correct the spelling of "documentation."

- `slither-documentation` uses [codex](https://platform.openai.com) to generate natspec documenation.
+ `slither-documentation` uses [codex](https://platform.openai.com) to generate natspec documentation.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
`slither-documentation` uses [codex](https://platform.openai.com) to generate natspec documenation.
`slither-documentation` uses [codex](https://platform.openai.com) to generate natspec documentation.

@@ -188,7 +188,7 @@ def _post_assignement_operation(self, expression: AssignmentOperation) -> None:
right = get(expression.expression_right)
operation: Operation
if isinstance(left, list): # tuple expression:
if isinstance(right, list): # unbox assigment
if isinstance(right, list): # unbox assignment
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the comment to correct the typo from "assignement" to "assignment."

-    def _post_assignement_operation(self, expression: AssignmentOperation) -> None:
+    def _post_assignment_operation(self, expression: AssignmentOperation) -> None:

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
if isinstance(right, list): # unbox assignment
if isinstance(right, list): # unbox assignment

@0xalpharush 0xalpharush changed the base branch from master to dev May 4, 2024 13:54
@0xalpharush 0xalpharush merged commit 4645ba5 into crytic:dev May 5, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants