Fix IR for top level functions with using-for

[smonicas]

Previously when an item in a top level function with using-for the IR was an HIGH_LEVEL_CALL instead of INTERNAL_CALL/LIBRARY_CALL. This was happening because in the conversion we only looked at the using-for for FunctionContract.

pragma solidity 0.8.24;

library Lib {
 function a(uint q) public {}
}
function c(uint z)  {}

using {Lib.a} for uint;
using {c} for uint;
function b(uint y)  {
 Lib.a(4);
 y.c();
 y.a();
}

Before

Top level functions
	Function c(uint256)
	Function b(uint256)
		Expression: Lib.a(4)
		IRs:
			LIBRARY_CALL, dest:Lib, function:Lib.a(uint256), arguments:['4'] 
		Expression: y.c()
		IRs:
			TMP_1(None) = HIGH_LEVEL_CALL, dest:y(uint256), function:c, arguments:[]  
		Expression: y.a()
		IRs:
			TMP_2(None) = HIGH_LEVEL_CALL, dest:y(uint256), function:a, arguments:[]  

After

Top level functions
	Function c(uint256)
	Function b(uint256)
		Expression: Lib.a(4)
		IRs:
			LIBRARY_CALL, dest:Lib, function:Lib.a(uint256), arguments:['4'] 
		Expression: y.c()
		IRs:
			INTERNAL_CALL, c(uint256)(y)
		Expression: y.a()
		IRs:
			LIBRARY_CALL, dest:Lib, function:Lib.a(uint256), arguments:['y'] 

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[0xalpharush]

This type doesn't match in the comment and the return signature is different than the definition. If we return an empty dict and not None, it isn't Optional

[0xalpharush]

Can we add the PR example as a regression test please?