Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved is_function_modified in upgradeability util #1938

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Improved is_function_modified in upgradeability util #1938

merged 3 commits into from
Jun 22, 2023

Conversation

webthethird
Copy link
Contributor

  • Avoids an IndexError from comparing the IRs of two nodes when the number of IRs don't match.
  • Improves variable encoding for comparison, i.e. for comparing a binary operation where one variable (or constant) is changed to a different variable. For example, return stateB == 62; should not be encoded the same as return stateB == 32;, nor should it be the same as return stateA == 62;.

@webthethird webthethird changed the base branch from master to dev May 24, 2023 18:09
@montyly montyly merged commit 23d3175 into crytic:dev Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xalpharush 0xalpharush 0xalpharush approved these changes

@montyly montyly Awaiting requested review from montyly montyly is a code owner

@smonicas smonicas Awaiting requested review from smonicas smonicas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webthethird @0xalpharush @montyly