Catch AssertionError and log context and raise again while parsing #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partial fix of crytic#1853 Opened PR per request in crytic#1854 AssertionError with stack trace can occur while parsing contracts that provides no context to what was parsed that threw the error as described in crytic#1853. This change catches this error, logs additional context, and then throws the error again. An example of the logging from code I am working on: ``` $ slither . ... Compiler run successful ERROR:SlitherSolcParsing: Failed to parse MyERC20Controller.constructor (contracts/MyERC20Controller.sol#19-25): (tokenX,tokenY) = IMyFactoryCallback(msg.sender).tokens() (success,data) = msg.sender.delegatecall(abi.encodeWithSelector(IMyFactoryCallback.newTokens.selector,tokenX,tokenY)) require(bool,string)(success,Factory new tokens failed) _tokens = abi.decode(data,(IMyERC20[6])) Traceback (most recent call last): File "~/slither/slither/__main__.py", line 810, in main_impl ) = process_all(filename, args, detector_classes, printer_classes) File "~/slither/slither/__main__.py", line 101, in process_all ... ``` Logging should make it easier for further issues from users to be easily understood and if necessary included in a bug report.
duelinggalois
requested review from
montyly,
0xalpharush and
smonicas
as code owners
|
@montyly, @0xalpharush, @smonicas Anything needed from me to merge, rebase or fix-up? |
0xalpharush
approved these changes
May 5, 2023
|
This is great, thanks @duelinggalois and @smonicas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial fix of #1853
Opened PR per request in #1854
AssertionError with stack trace can occur while parsing contracts that provides no context to what was parsed that threw the error as described in #1853. This change catches this error, logs additional context, and then throws the error again.
An example of the logging from code I am working on:
Logging should make it easier for further issues from users to be easily understood and if necessary included in a bug report.