Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test case to show the bug described in #1853 #1854

Closed
wants to merge 2 commits into from
Closed

Added test case to show the bug described in #1853 #1854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c54ecbb
Added test case to show the bug described in #1853
duelinggalois Apr 22, 2023
d5285b4
Catch AssertionError and log context and raise again while parsing
duelinggalois Apr 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions slither/solc_parsing/slither_compilation_unit_solc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,6 +742,14 @@ def _convert_to_slithir(self) -> None:
self._underlying_contract_to_parser[contract].log_incorrect_parsing(
f"Impossible to generate IR for {contract.name}.{func.name} ({func.source_mapping}):\n {e}"
)
except AssertionError as e:
# Provide contex to user about code that failed beyond AssertionError and stack trace.
duelinggalois marked this conversation as resolved.
Show resolved Hide resolved
func_expressions = "\n".join([f'\t{ex}' for ex in func.expressions])
logger.error(
f"Failed to parse {contract.name}.{func.name} ({func.source_mapping}):\n "
duelinggalois marked this conversation as resolved.
Show resolved Hide resolved
f"{func_expressions}")
raise e
duelinggalois marked this conversation as resolved.
Show resolved Hide resolved


contract.convert_expression_to_slithir_ssa()

Expand Down
1 change: 1 addition & 0 deletions tests/e2e/solc_parsing/test_ast_parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,7 @@ def make_version(minor: int, patch_min: int, patch_max: int) -> List[str]:
Test("user_defined_value_type/in_parenthesis-0.8.8.sol", ["0.8.8"] + make_version(8, 10, 15)),
Test("user_defined_value_type/top-level-0.8.8.sol", ["0.8.8"] + make_version(8, 10, 15)),
Test("user_defined_value_type/using-for-0.8.8.sol", ["0.8.8"] + make_version(8, 10, 15)),
Test("user_defined_value_type/decode_contract_array.sol", VERSIONS_08),
Test("bytes_call.sol", ["0.8.12"]),
Test("modifier_identifier_path.sol", VERSIONS_08),
Test("free_functions/libraries_from_free.sol", ["0.8.12"]),
Expand Down
Binary file added ...ing/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.0-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ing/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.1-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ng/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.10-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ng/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.11-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ng/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.12-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ng/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.13-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ng/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.14-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ng/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.15-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ing/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.2-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ing/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.3-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ing/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.4-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ing/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.5-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ing/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.6-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ing/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.7-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ing/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.8-compact.zip
View file
Open in desktop
Binary file not shown.
Binary file added ...ing/test_data/compile/user_defined_value_type/decode_contract_array.sol-0.8.9-compact.zip
View file
Open in desktop
Binary file not shown.
6 changes: 6 additions & 0 deletions ...g/test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.0-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions ...g/test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.1-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions .../test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.10-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions .../test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.11-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions .../test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.12-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions .../test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.13-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions .../test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.14-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions .../test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.15-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions ...g/test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.2-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions ...g/test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.3-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions ...g/test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.4-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions ...g/test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.5-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions ...g/test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.6-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions ...g/test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.7-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions ...g/test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.8-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
6 changes: 6 additions & 0 deletions ...g/test_data/expected/user_defined_value_type/decode_contract_array.sol-0.8.9-compact.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"I": {},
"C": {
"test_decode(bytes)": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: EXPRESSION 1\n\"];\n}\n"
}
}
11 changes: 11 additions & 0 deletions tests/e2e/solc_parsing/test_data/user_defined_value_type/decode_contract_array.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
pragma experimental ABIEncoderV2;

interface I {}

contract C {
I[6] interfaceArray;

function test_decode(bytes memory data) public {
interfaceArray = abi.decode(data, (I[6]));
}
}