Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform cross-contract taint analysis from diff of two upgrade versions #1816

Merged
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
072cb0b
Find tainted functions/variables from external calls
webthethird Mar 29, 2023
4b6dd02
Find contracts tainted by inheriting a tainted contract
webthethird Mar 30, 2023
0deff18
Add docstring to `tainted_inheriting_contracts`
webthethird Mar 30, 2023
5967958
Black
webthethird Mar 30, 2023
675dbea
Get tainted variables in `tainted_inheriting_contracts`
webthethird Mar 31, 2023
d88bba4
Fix too many values to unpack in test_upgradeability_util.py
webthethird Mar 31, 2023
cba0dc9
Add python types
webthethird Mar 31, 2023
386c3e1
Pylint and black
webthethird Mar 31, 2023
20f5825
Pylint and black
webthethird Mar 31, 2023
c786658
Merge remote-tracking branch 'crytic/slither/dev' into dev-upgradeabi…
webthethird Mar 31, 2023
f585d2b
Add TODO
webthethird Mar 31, 2023
2b330a1
Tweak how tainted variables are handled
webthethird Apr 3, 2023
da045d6
Make TaintedExternalContract a regular class
webthethird Apr 4, 2023
d1b34b6
Avoid string comparison
webthethird Apr 4, 2023
85c22f4
Avoid re-defining `contracts` in `tainted_inheriting_contracts`
webthethird Apr 4, 2023
38acd93
Add inline comments
webthethird Apr 4, 2023
98a5cf0
Use canonical_name in comparisons
webthethird Apr 4, 2023
1e73979
Fix expected tainted funcs, since we changed what's considered tainted
webthethird Apr 4, 2023
178960f
Simplify by removing `TaintedFunction` and `TaintedVariable` classes
webthethird Apr 4, 2023
3bcefac
Black
webthethird Apr 4, 2023
ae7f0b2
Only check internal calls to Functions
webthethird Apr 10, 2023
ca82da0
Update compare docstring
webthethird Apr 17, 2023
853051e
Reduce tainted variables to only written
webthethird Apr 17, 2023
823337e
Update test
webthethird Apr 17, 2023
6ccc8cf
Black
webthethird Apr 17, 2023
ef2eadc
Update test_upgrades_compare to test cross-contract taint
webthethird Apr 19, 2023
2cdc544
Make cross-contract taint optional in `compare`
webthethird May 10, 2023
1064185
Update test
webthethird May 10, 2023
af7279a
Update docstring
webthethird May 10, 2023
6a10e0a
Merge branch 'dev' into dev-upgradeability-util-cross-contract-taint
webthethird May 19, 2023
4ff33c0
Merge branch 'dev' into dev-upgradeability-util-cross-contract-taint
webthethird May 25, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'dev' into dev-upgradeability-util-cross-contract-taint
webthethird authored May 25, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 4ff33c045ff416c6b84c85dbaebe8a00e4a7468a

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.