Made inclusion of GENERIC_TAINT sources (msg.*, tx.origin) optional in taint-checking #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n taintedness checking by adding ignore_generic_taint parameter to is_tainted() and is_tainted_ssa() functions, with the default value being FALSE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made inclusion of
GENERIC_TAINTsources (msg.*, tx.origin) optional in taint-checking by addingignore_generic_taintparameter tois_tainted()andis_tainted_ssa()functions, with the default value beingFALSE.Motivation: There are analyses where one would like to ignore these generic taint sources but only include taint coming from other user-controlled function arguments.
Validation:
tests/controlled_delegatecall.solpasses with two violations as expected.scripts/travis_test_data_dependency.shpasses.