Fix Truffle invocation conflict on Windows #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As we are fixing Windows support: if a truffle version is specified in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to resolve #173 . The
truffle compilecommand invoked through slither will fail on Windows due to naming conflicts. On Windows,.JSis an executable extension by default (see thePATHEXTenvironment variable), which confuses windows into invokingtruffle.jsinstead oftruffle.cmd.Truffle's own website suggests a few fixes:
https://truffleframework.com/docs/truffle/reference/configuration#resolving-naming-conflicts-on-windows
The only fix which does not require the user modifying their environment is to explicitly invoke
truffle.cmd. This seems simplistic and non-problematic, so I have added a switch to__main__.pywhich invokestruffle.cmdif on Windows, otherwise simplytruffleis invoked.This has fixed truffle invocation on my Windows system.