Make type information of NewArray more precise #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Troublor
requested review from
montyly,
0xalpharush and
smonicas
as code owners
0xalpharush
reviewed
Apr 1, 2023
0xalpharush
reviewed
Apr 2, 2023
|
I think this makes sense but it will need @montyly's review too. Would you make this change against |
The base branch of this PR has been made to |
0xalpharush
approved these changes
Apr 25, 2023
|
@Troublor Do you mind resolving the merge conflicts please? |
# Conflicts: # tests/unit/slithir/test_ssa_generation.py
@0xalpharush Conflict fixed. |
|
This is a great improvement, thanks @Troublor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1776, i.e., incorrect
array_typeinNewArrayoperation.This PR also makes the
array_typefield more precise by including the length of the fixed-sized nested array.