Fix IR operation when initializing array with one-element array literal #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Troublor
requested review from
montyly,
0xalpharush and
smonicas
as code owners
|
|
|
The failure for slither-read-storage is unrelated and fixed in #1743 |
|
I found the error messages of |
|
Nice catch. Thanks @Troublor |
duckki
pushed a commit
to CertiKProject/slither-certik
that referenced
this pull request
Apr 8, 2023
- since we have our own solution (/pull/26) https://github.com/CertiKProject/slither-task/issues/383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1748
I added one test to reveal the bug, but I am not sure whether
tests/test_ssa_generation.pyis the right place to put it. Correct me if it is not the right place.As I mentioned in the comments of #1748, the root cause is that the AST visitor unpacks the right-hand side value of
arr = [1]when visiting the AST tree. However, it is not possible to decide whether the tuple should be unpacked or not when visitingTupleExpressionAST node.So, the workaround I made in this PR is to recover the array literal when we later find (at L223 of file expression_to_slithir.py) that an array is being initialized.