Code

Add upgradeability utils#1757

Code

Merged

montyly merged 56 commits intocrytic:devcrytic/slither:devfrom webthethird:dev-upgradeability-utilswebthethird/slither:dev-upgradeability-utilsCopy head branch name to clipboardMar 30, 2023

+1,562-17

Commits

Commits on Feb 27, 2023

• Start slither.utils.upgradeability

  webthethird

  committed
  d04fc9e

• Merge remote-tracking branch 'crytic/slither/dev' into dev-compare-upgrades

  Show description for ec537e5
  webthethird

  committed
  ec537e5

• Implement compare(v1: Contract, v2: Contract)

  Show description for f08d2af
  webthethird

  committed
  f08d2af

• Pylint

  Show description for ebd2201
  webthethird

  committed
  ebd2201

Commits on Feb 28, 2023

• Add return statement (whoops!)

  webthethird

  committed
  04c71c2

• Merge remote-tracking branch 'crytic/slither/dev' into dev-compare-upgrades

  webthethird

  committed
  6b0124c

• Also consider an unmodified function tainted if it reads/writes the same state variable(s) as a new/modified function

  webthethird

  committed
  5b361e8

• Make pylint happy (reduce branches)

  webthethird

  committed
  6b9d21a

• Avoid duplicates, constants and immutables

  Show description for 3757601
  webthethird

  committed
  3757601

• Avoid constructor

  Show description for 770ca81
  webthethird

  committed
  770ca81

• Avoid slitherConstructorConstantVariables()

  Show description for 596b4d0
  webthethird

  committed
  596b4d0

• Avoid slitherConstructorConstantVariables()

  Show description for 480ee60
  webthethird

  committed
  480ee60

Commits on Mar 11, 2023

• Bump to re-run CI tests

  webthethird

  committed
  37554ec

Commits on Mar 12, 2023

• Add additional upgradeability utils

  Show description for f1947bb
  webthethird

  committed
  f1947bb

• Add docstrings

  webthethird

  committed
  8181fae

• Separate get_proxy_implementation_var

  Show description for 4c57168
  webthethird

  committed
  4c57168

Commits on Mar 14, 2023

• pylint

  webthethird

  committed
  09128ab

• Merge remote-tracking branch 'crytic/slither/dev' into dev-upgradeability-utils

  Show description for a6d49d5
  webthethird

  committed
  a6d49d5

• Redesign utils.upgradeability.is_function_modified

  Show description for 3655708
  webthethird

  committed
  3655708

• Handle sload from slot in delegatecall args

  Show description for c195a15
  webthethird

  committed
  c195a15

Commits on Mar 16, 2023

• Merge remote-tracking branch 'crytic/slither/dev' into dev-upgradeability-utils

  webthethird

  committed
  ccb98d8

• Minor bug fixes

  webthethird

  committed
  317af45

• Include variables touched by tainted functions

  webthethird

  committed
  9f4be7d

• Copy/paste and tweak encode_ir to compare ir

  Show description for 6ff59f9
  webthethird

  committed
  6ff59f9

• Add test for slither.utils.upgradeability.compare

  Show description for 701c8f3
  webthethird

  committed
  701c8f3

• pylint

  webthethird

  committed
  a035d27

• Rename shadowed var

  webthethird

  committed
  c5b5463

Commits on Mar 17, 2023

• Return six lists instead of dictionary of lists

  webthethird

  committed
  5622230

• Rewrite test for utils.upgradeability

  webthethird

  committed
  c159f56

• Use .state_variables_ordered and .is_constructor_variables

  webthethird

  committed
  a6f6fc0

• Add Contract.fallback_function and .receive_function properties

  webthethird

  committed
  af6727c

• Use Contract.fallback_function

  webthethird

  committed
  26f80cf

• Handle hardcoded slot sloaded in delegatecall

  Show description for 1a54d0d
  webthethird

  committed
  1a54d0d

• Document when a newly created variable can be returned

  webthethird

  committed
  24dad03

• Comment when a newly created variable can be returned

  Show description for 9a9acbe
  webthethird

  committed
  9a9acbe

• Also search parent_func.returns in find_delegate_from_name

  webthethird

  committed
  f148bbc

• Remove unused TEST_upgrade_diff.json

  webthethird

  committed
  722a343

• Handle named variable declared in assembly

  Show description for fc1b94c
  webthethird

  committed
  fc1b94c

• pylint and black

  webthethird

  committed
  cbbcb8c

• Update upgradeability util tests

  Show description for bff30a3
  webthethird

  committed
  bff30a3

• Add get_missing_vars to util, use it in compare

  webthethird

  committed
  574afbe

• Use get_missing_vars in MissingVariable detector

  webthethird

  committed
  f216817

• Fix compare return signature

  webthethird

  committed
  1588334

• Handle sload from integer slot, i.e., sload(0)

  webthethird

  committed
  0e708e6

• Comment out ZosProxy test for now

  Show description for 9192fef
  webthethird

  committed
  9192fef

• Add SynthProxy.sol to test_upgradeability_util.py test

  webthethird

  committed
  72c6d78

Commits on Mar 23, 2023

• Merge remote-tracking branch 'crytic/slither/dev' into dev-upgradeability-utils

  Show description for a292d8d
  webthethird

  committed
  a292d8d

Commits on Mar 24, 2023

• Add types to function signatures

  webthethird

  committed
  78e2ea3

• Pylint

  webthethird

  committed
  c094818

• Black

  webthethird

  committed
  0ac4c01

Commits on Mar 25, 2023

• Create separate encore_var_for_compare

  webthethird

  committed
  2695243

Commits on Mar 27, 2023

• Fix ir encoding in comparison

  webthethird

  committed
  47c92f8

Commits on Mar 28, 2023

• Merge remote-tracking branch 'crytic/slither/dev' into dev-upgradeability-utils

  webthethird

  committed
  ac88e8c

• Move upgradeability util test files

  webthethird

  committed
  be0e405

• Add Path import

  webthethird

  committed
  8731a92

• Add test for Contract.fallback_function

  Show description for 5703b9d
  webthethird

  committed
  5703b9d