Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests from 1625 #1741

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Improve tests from 1625 #1741

merged 1 commit into from
Mar 10, 2023

Conversation

montyly
Copy link
Member

@montyly montyly commented Mar 10, 2023

  • Remove the conftest usage
  • Use explicit solc version on the tests

#1625 introduced the usage of the conftest, which is great for genericity, however:

  • The solution used the global env, instead of the solc select python API
  • I think all the tests should use an explicit solc version. Using the "latest" solc if nothing is mentioned is more error-prone
  • The logic has a bug, as it does not work well when the tests are re-ordered. I haven't explored why, but it can be shown here: https://github.com/crytic/slither/actions/runs/4383769904/jobs/7674418982

@montyly montyly merged commit 829f7eb into dev Mar 10, 2023
@montyly montyly deleted the fix-1625 branch March 10, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants