deregister_detector

[sidarth16]

This function would be helpful to de-register a detector class from the list of detectors already registered with the slither object.

[sidarth16]

The major issue it solves is the reusing of the same slither Object for multiple detector classes.
Example:

from slither.detectors.all_detectors import *
from slither.slither import Slither

sl = Slither("<contract_address>")

detectors = [TxOrigin, ReentrancyBenign, ReentrancyEth, UncheckedTransfer, UncheckedSend]
for d in detectors:
    sl.register_detector(d)  
r1 = sl.run_detectors()

# Now I no more want TxOrigin in the context slither object detectors

sl.unregister_detector(TxOrigin)

r2 = sl.run_detectors()

Thus, We are now able to re-run detectors , reusing the same slither object. We don't need to declare new slither object for each combination of detector classes.

Here r1, contains results of TxOrigin , while r2 does not contain results of TxOrigin .

[0xalpharush]

It would be great to have a test case. I haven't looked into it but this might have weird effects on detector result filtering.

[montyly]

Note that some detectors cache the results (ex: the reentrancies detectors), so running multiple times will not lead to a fresh run.

I am not sure what is your goal with this API, but you should be aware that detectors are not side-effects free ;)