-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more types hints #1666
Merged
Merged
Add more types hints #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR contains several minor bug fixes in the API. They will be documented before the PR is merged |
Closed
In addition to the types, this fixes:
|
0xalpharush
reviewed
Mar 10, 2023
0xalpharush
reviewed
Mar 10, 2023
@@ -70,17 +72,20 @@ def _visit( | |||
if ir.lvalue and not isinstance(ir.lvalue, (TemporaryVariable, ReferenceVariable)): | |||
variables_written.add(ir.lvalue) | |||
|
|||
lvalue = ir.lvalue | |||
lvalue: Any = ir.lvalue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking but we should type ir.lvalue so this can be Optional[...]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A general issue is related to the usage of the
type
, as it sometimes return a list of types, which might need a bit of refactoring. MoreoverExpressionTyped
has derived class that redefinestype
Another source of issues that will require some refactoring is the handling of top level function in the data dependencies. The analysis was not built with top level function in mind, and needs to be improved